Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ECLGraph::haveConnData so that 1D and 2D cases are handled c… #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkip
Copy link
Member

@vkip vkip commented Nov 14, 2016

…orrectly (in these cases missing dimension arrays are not present in the data file).

…orrectly (in these cases missing dimension arrays are not present in the data file).
@atgeirr
Copy link
Member

atgeirr commented Nov 14, 2016

Sounds like a useful and important fix, thanks! Assigning @bska to check and merge this (if OK). There are some annoying tab-vs-spaces issues (we try to go with spaces exclusively), but we can fix that.

@bska
Copy link
Member

bska commented Nov 14, 2016

This will return true if any of the (I,J,K) vectors are present. We need it to return true only if all the (relevant) vectors are present.

@atgeirr
Copy link
Member

atgeirr commented Nov 14, 2016

I am a little confused now: if you are running a 1d case, it will actually be represented as a 3d case, but with a string of cells in only one direction (for example a 1 x 1 x 10 grid), correct? If so, would not the simulator still output fluxes in the I+ and J+ directions (that would be zero)?

Do you have a case that shows this, that causes the current code to fail?

@atgeirr
Copy link
Member

atgeirr commented Dec 27, 2017

Is this something we should resurrect, or just close @vkip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants