Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- changed assert to throw #829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

- changed assert to throw #829

wants to merge 1 commit into from

Conversation

hnil
Copy link
Member

@hnil hnil commented Sep 21, 2023

  • changed asserts to throw
  • added checks on positivity of physical quantities
    -Saturation is not checked

- added more tests

#ifndef NDEBUG
// some safety checks in debug mode
#ifndef NOT_CHECK_STATE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new name (that nobody knows)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Becase NDEBUG is on in production code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Becase NDEBUG is on in production code.

I think you meant NDEBUG is off in production code with default -DWITH_NDEBUG=0

-O3 -DNDEBUG -mtune=native -UNDEBUG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants