Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hacking to register the parameter ForceDisableFluidInPlaceOutput #5926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitPaean
Copy link
Member

@GitPaean GitPaean commented Jan 29, 2025

Instantiating FluidSystem<0> at this stage due to how it is implemented.

After #5882, the flowexp_comp can not be run anymore.

Not totally sure this is the proper fix, but just bring it up here to start the conversation.

@GitPaean GitPaean requested review from akva2 and kjetilly January 29, 2025 13:39
@GitPaean
Copy link
Member Author

jenkins build this please

@akva2
Copy link
Member

akva2 commented Jan 29, 2025

i see no hack here. also don't see why you override if you're just going to call the base class implementation.

@GitPaean
Copy link
Member Author

i see no hack here. also don't see why you override if you're just going to call the base class implementation.

It is a good point. There was an empty function there before and I did not think about it.

@akva2
Copy link
Member

akva2 commented Jan 29, 2025

i get that but that was also the problem in the first place :)

@GitPaean
Copy link
Member Author

i see no hack here. also don't see why you override if you're just going to call the base class implementation.

It is a good point. There was an empty function there before and I did not think about it.

The empty function might indicate they wanted some local parameters for this module, but there was not yet.

FluidSystem<0> at this stage due to how it is implemented
@GitPaean GitPaean force-pushed the fixing_exp_comp_running branch from 7bf366e to dd9a7db Compare January 29, 2025 13:50
@GitPaean
Copy link
Member Author

because we use the following code in flowexp_comp.cpp,

int
main(int argc, char** argv)
{
    using TypeTag = Opm::Properties::TTag::FlowExpCompProblem<0>;
    Opm::registerEclTimeSteppingParameters<double>();

we need INSTANTIATE_COMP(0) in GenericOutputBlackoilModule.cpp.

@GitPaean
Copy link
Member Author

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants