Not creating identity matrix as reverse of singular well matrix for StandardWell. #6614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
after #6608 went in, let us test again. |
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
Great! The jenkins is green, which means the several regression failures earlier (around 6 or 7) are all related to / fixed through #6608 . Will clean up this PR and hopefully get it merged. |
in StandardWellEquations.
GitPaean
force-pushed
the
rethrow_numericalproblem
branch
from
3761a66 to
2f18b68
Compare
Member
Author
|
jenkins build this failure_report please |
GitPaean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referring to the discussion in #6608 .
When a singular matrix assembled for StandardWell, we should not create an identity matrix as a inverse to continue.
With #6608 merged, the singular matrix from StandardWell assembling during well testing from all the regression tests looks like gone, this PR does not introduce any regression failures.
This also makes the processing of the singular well matrix consistent between StandardWell and MultisegmentWell.