WIP use IPR in gaslift optimization #6648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins build this failure_report please |
totto82
added
the
manual:irrelevant
Member
|
If the IPR is reliable, the textbook solution is to look for the intersection of the VFP curve and IPR curve directly, that was the first implementation. But back then the IPR calculation for MSW was problematic, then it shifted to current iteration based. Maybe we can revisit the old way given the improved IPR calculation? |
Member
Author
Yes, I will test that. I am just testing this step-by-step to understand the implications of the changes. |
Member
Author
|
replace by #6653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use IPR when computing BHP from THP limit.
Also, avoid re-computing max_perf_pressure.
Needs more testing.