-
Notifications
You must be signed in to change notification settings - Fork 132
Move linear system export and make it safer. #6677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nrseman any comments? |
|
jenkins build this please |
Looks like a reasonable solution to me. Did you verify that it works? |
|
@atgeirr, did you have a chance to verify that the export functionality still works? |
Not yet, will try to get it done this week. |
- Remove the print...() functions that only wrote partial information. If this is needed it may be done by extracting from the export...() output instead. - Move the export...() functions to a separate file. Keeping the top-level function though, and the logic it contained relating to avoiding re-writing the sparsity pattern. - Make the implementation safer by removing all use of sprintf().
|
Ok, have made a few minor changes and verified that it writes the output (not written a tool to read it back in and check though). Taking it out of draft. This is still very much a "tool for the debugging developer", as I have added no error checking for example, so it is easy to make it go kaboom (by passing a nonexisting directory for example), but I leave improving it to future interested parties. |
|
jenkins build this please |
akva2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you point out yourself, this is not the end of the story, but it is a clear improvement so in she goes.
|
Thank you gents. This utility is bread and butter for me. |
Intended to remove unrelated export functionality from the linearization class, and avoid sprintf() which generates tons of warnings on clang.