Merge pull request #1100 from OPUS4/v4.8.0.2

OPUS 4.8.0.2 Patch Release
OPUS4 · Aug 29, 2023 · 3eea34e · 3eea34e
2 parents d4f3cb5 + 813dabd
commit 3eea34e
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,10 @@
 # OPUS 4 Change Log
 
+## Release 4.8.0.2 - 2023-08-29
+
+https://github.com/OPUS4/application/issues/1068
+https://github.com/orgs/OPUS4/projects/56
+
 ## Release 4.8.0.1 - 2023-08-15
 
 OPUS 4.8.0.1 Project on GitHub

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,5 +1,10 @@
 # OPUS 4 Release Notes
 
+## Patch Release 4.8.0.2 - 2023-08-29
+
+Es wurde ein Fehler bei der Javascript-Validierung von ISSNs behoben. 
+https://github.com/OPUS4/application/issues/1098
+
 ## Patch Release 4.8.0.1 - 2023-08-15
 
 Es wurde ein Fehler behoben, bei dem Personen im Metadaten-Formular 

diff --git a/application/configs/application.ini b/application/configs/application.ini
@@ -70,7 +70,7 @@ name = 'OPUS 4'
 logoLink = home
 security = 1
 workspacePath = APPLICATION_PATH "/workspace"
-version = 4.8.0.1
+version = 4.8.0.2
 update.latestVersionCheckUrl = "https://api.github.com/repos/opus4/application/releases/latest"
 
 ; Determines the implementation of the OPUS 4 data model

diff --git a/public/layouts/opus4/js/validation.js b/public/layouts/opus4/js/validation.js
@@ -181,11 +181,17 @@ IssnValidation.prototype.validateISSN = function (value) {
 IssnValidation.prototype.calculateCheckDigitISSN = function (value) {
     var z          = value;
     var checkdigit = 0;
-    var check      = (8 * z[0] + 7 * z[1] + 6 * z[2] + 5 * z[3] + 4 * z[5] + 3 * z[6] + 2 * z[7]);
-    if (11 - (check % 11) === 10) {
-        checkdigit = "X";
-    } else {
-        checkdigit = 11 - (check % 11);
+    var check      = (8 * z[0] + 7 * z[1] + 6 * z[2] + 5 * z[3] + 4 * z[5] + 3 * z[6] + 2 * z[7]) % 11;
+
+    switch (check) {
+        case 0:
+            checkdigit = "0";
+            break;
+        case 1:
+            checkdigit = "X";
+            break;
+        default:
+            checkdigit = 11 - check;
     }
 
     return checkdigit;