Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

particle diagnostics for time and angle #189

Closed
wants to merge 61 commits into from
Closed

particle diagnostics for time and angle #189

wants to merge 61 commits into from

Conversation

tyounkin
Copy link
Collaborator

This pull request addresses and closes #188

@tyounkin tyounkin marked this pull request as ready for review January 10, 2024 18:11
@tyounkin tyounkin force-pushed the particle_diagnostics_time_angle branch from 510a970 to f5dd266 Compare January 10, 2024 18:19
@stonecoldhughes stonecoldhughes force-pushed the particle_diagnostics_time_angle branch 2 times, most recently from 11a5747 to 6e21101 Compare January 22, 2024 18:08
@stonecoldhughes stonecoldhughes force-pushed the particle_diagnostics_time_angle branch from 6e21101 to 1df4d41 Compare February 9, 2024 19:06
@hayes2419
Merge pull request #198 from ORNL-Fusion/main
b548cfa 
rebasing to wrap in readme updates
@hayes2419
Update gitr.cpp with ANGLE particle diagnostics
66c605a
@hayes2419
Update gitrInput.cfg of circle example to include part diag angle inputs
c1957ec 
added bin_edge_0_angle and bin_edge_1_angle to all be example angles that might or might not be useful; n_bins_angle was set to 100 arbitrarily
@hayes2419
Update particle_diagnostics.h with angle inputs
bd941dc
@hayes2419
Update gitr.cpp to set ncDims and ncVars for ANGLE particle diagnostics
8aaf327
@hayes2419
Update particle_diagnostics.cpp to initialize angle diagnostics
c1cd3ed 
actual work to append to the angle histogram still needs to be done, but will be less time-consuming with Tim tomorrow
@hayes2419
Update particle_diagnostics.cpp to include ANGLE histograms
5ff8d4f
@hayes2419
Update Particles.h to include transitAngle field
cb70854
@hayes2419
Update particle_diagnostics.cpp to fix typos
9425ff1
@hayes2419
Update particle_diagnostics.h to add in *_particle_angle_histogram
c57299c
@hayes2419
fix typos in gitr.cpp
c214194
@hayes2419
Update particle_diagnostics.cpp to fix typo
674805a
@hayes2419
Update gitr.cpp to fix problem with dims_part_hist
b86933e 
was giving both n_bins_time and n_bins_angle to both time and angle histograms, instead of giving them independent sets of dimensions
@hayes2419
Update gitr.cpp to declare new dims varnames
0fcbfa9
@hayes2419
Update gitr.cpp to add perpDist to history.nc
4edad84
@hayes2419
Update gitr.cpp to replace perpDist with perpDistanceToSurface
4a08a26
@hayes2419
Update gitr.cpp to declare perpDistanceToSurface varnames
6c030ab
@hayes2419
Update history.h to include perpDistanceToSurface
cac1e4d
@hayes2419
Update history.h to fix typos
1b916ab
hayes2419 and others added 28 commits March 5, 2024 17:16
@hayes2419
Update particle_diagnostics.h to add log(angle) capability
df24c91
@hayes2419
Update gitr.cpp to add log(angle) capability
550b152
@hayes2419
Update particle_diagnostics.cpp to attempt to add behavior for times_…
1884cfa 
…logarithmic==0
@hayes2419
Update particle_diagnostics.h to add ; typo
133fc64
@hayes2419
Update particle_diagnostics.cpp to debug if/else syntax
199f665
@hayes2419
Update particle_diagnostics.cpp debug attempt 3
5d9dc7f
@hayes2419
Update particle_diagnostics.cpp printf debugging 1
70902bd
@hayes2419
Update particle_diagnostics.cpp printf debugging 2
3685baf
@hayes2419
Update particle_diagnostics.cpp printf debug 3
55cf0b3
@hayes2419
Update particle_diagnostics.cpp printf debug 4
39bc030
@hayes2419
Update gitr.cpp to add nSurfaces to particle_diagnostics
fd4c9d2
@hayes2419
Update particle_diagnostics.cpp printf debug 4
1827605
@hayes2419
Update particle_diagnostics.cpp add comma
7fd7f17
@hayes2419
Update particle_diagnostics.h to add nSurfaces declaration
37033c6
@hayes2419
Update particle_diagnostics.h typo
5d0e0c2
@hayes2419
Update particle_diagnostics.h typo
5e1da89
@hayes2419
Update particle_diagnostics.cpp typo
c5bced9
@hayes2419
Update particle_diagnostics.cpp remove printf debugging statements
ce4e343
@hayes2419
Update particle_diagnostics.cpp to try to debug nP issue
ac827b5
@hayes2419
Update particle_diagnostics.cpp to debug nP issue
b753e70
@hayes2419
Update particle_diagnostics.cpp to set weight to 0 at the end of the …
3e7cbd5 
…file inside the hitWall ifstatement
turn off print statement debugging because the error was that you got…
8f66230 
…ta cast all booleans as 'true' or 'false'
begin debugging angle=0 when charge=1
55cf8a1
deactivated file_io_tests, debug mode, cuda=1
bba6f2b
@hayes2419
hopefully resolving merge conflict in noninteractive podman .sh bashfile
6146f8f
@hayes2419
maintenance
30f28b3
@hayes2419
Update particle_diagnostics.cpp to comment out debug print statement
cc8066c
@hayes2419
Update compile_time_options.cmake to build with Release mode by default
e6b1106
@stonecoldhughes
Copy link
Collaborator

already merged into dev instead of main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature addition - Particle diagnostics - angle of gyration
3 participants
@tyounkin @stonecoldhughes @hayes2419