Add GDALDataset::ReportUpdateNotSupportedByDriver() and use it in dri…

…vers
OSGeo · Jan 26, 2025 · 48d769f · 48d769f
1 parent dbbda6e
commit 48d769f
Show file tree

Hide file tree

Showing 69 changed files with 89 additions and 206 deletions.
diff --git a/frmts/adrg/adrgdataset.cpp b/frmts/adrg/adrgdataset.cpp
@@ -1616,9 +1616,7 @@ GDALDataset *ADRGDataset::Open(GDALOpenInfo *poOpenInfo)
     {
         if (poOpenInfo->eAccess == GA_Update)
         {
-            CPLError(CE_Failure, CPLE_NotSupported,
-                     "The ADRG driver does not support update access to "
-                     "existing datasets.");
+            ReportUpdateNotSupportedByDriver("ADRG");
             return nullptr;
         }
 

diff --git a/frmts/adrg/srpdataset.cpp b/frmts/adrg/srpdataset.cpp
@@ -1615,9 +1615,7 @@ GDALDataset *SRPDataset::Open(GDALOpenInfo *poOpenInfo)
 
         if (poOpenInfo->eAccess == GA_Update)
         {
-            CPLError(CE_Failure, CPLE_NotSupported,
-                     "The SRP driver does not support update access to existing"
-                     " datasets.\n");
+            ReportUpdateNotSupportedByDriver("SRP");
             return nullptr;
         }
 

diff --git a/frmts/aigrid/aigdataset.cpp b/frmts/aigrid/aigdataset.cpp
@@ -636,9 +636,7 @@ GDALDataset *AIGDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         AIGClose(psInfo);
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The AIG driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("AIG");
         return nullptr;
     }
     /* -------------------------------------------------------------------- */

diff --git a/frmts/airsar/airsardataset.cpp b/frmts/airsar/airsardataset.cpp
@@ -523,9 +523,7 @@ GDALDataset *AirSARDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The AIRSAR driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("AIRSAR");
         CSLDestroy(papszMD);
         return nullptr;
     }

diff --git a/frmts/blx/blxdataset.cpp b/frmts/blx/blxdataset.cpp
@@ -124,9 +124,7 @@ GDALDataset *BLXDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         delete poDS;
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The BLX driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("BLX");
         return nullptr;
     }
 

diff --git a/frmts/bsb/bsbdataset.cpp b/frmts/bsb/bsbdataset.cpp
@@ -818,9 +818,7 @@ GDALDataset *BSBDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The BSB driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("BSB");
         return nullptr;
     }
 

diff --git a/frmts/ceos/ceosdataset.cpp b/frmts/ceos/ceosdataset.cpp
@@ -155,9 +155,7 @@ GDALDataset *CEOSDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         CEOSClose(psCEOS);
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The CEOS driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("CEOS");
         return nullptr;
     }
     /* -------------------------------------------------------------------- */

diff --git a/frmts/ceos2/sar_ceosdataset.cpp b/frmts/ceos2/sar_ceosdataset.cpp
@@ -1791,10 +1791,7 @@ GDALDataset *SAR_CEOSDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(
-            CE_Failure, CPLE_NotSupported,
-            "The SAR_CEOS driver does not support update access to existing"
-            " datasets.\n");
+        ReportUpdateNotSupportedByDriver("SAR_CEOS");
         return nullptr;
     }
 

diff --git a/frmts/coasp/coasp_dataset.cpp b/frmts/coasp/coasp_dataset.cpp
@@ -377,9 +377,7 @@ GDALDataset *COASPDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The COASP driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("COASP");
         return nullptr;
     }
 

diff --git a/frmts/cosar/cosar_dataset.cpp b/frmts/cosar/cosar_dataset.cpp
@@ -176,9 +176,7 @@ GDALDataset *COSARDataset::Open(GDALOpenInfo *pOpenInfo)
     /* -------------------------------------------------------------------- */
     if (pOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The COSAR driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("COSAR");
         return nullptr;
     }
 

diff --git a/frmts/ctg/ctgdataset.cpp b/frmts/ctg/ctgdataset.cpp
@@ -415,9 +415,7 @@ GDALDataset *CTGDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The CTG driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("CTG");
         return nullptr;
     }
 

diff --git a/frmts/dimap/dimapdataset.cpp b/frmts/dimap/dimapdataset.cpp
@@ -512,9 +512,7 @@ GDALDataset *DIMAPDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The DIMAP driver does not support update access to existing "
-                 " datasets.");
+        ReportUpdateNotSupportedByDriver("DIMAP");
         return nullptr;
     }
     /* -------------------------------------------------------------------- */

diff --git a/frmts/envisat/envisatdataset.cpp b/frmts/envisat/envisatdataset.cpp
@@ -899,9 +899,7 @@ GDALDataset *EnvisatDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         EnvisatFile_Close(hEnvisatFile);
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The ENVISAT driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("ENVISAT");
         return nullptr;
     }
     /* -------------------------------------------------------------------- */

diff --git a/frmts/fit/fitdataset.cpp b/frmts/fit/fitdataset.cpp
@@ -836,9 +836,7 @@ GDALDataset *FITDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The FIT driver does not support update access to existing"
-                 " files.\n");
+        ReportUpdateNotSupportedByDriver("FIT");
         return nullptr;
     }
 

diff --git a/frmts/gff/gff_dataset.cpp b/frmts/gff/gff_dataset.cpp
@@ -190,9 +190,7 @@ GDALDataset *GFFDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The GFF driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("GFF");
         return nullptr;
     }
 

diff --git a/frmts/gif/biggifdataset.cpp b/frmts/gif/biggifdataset.cpp
@@ -284,9 +284,7 @@ GDALDataset *BIGGIFDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The GIF driver does not support update access to existing"
-                 " files.\n");
+        ReportUpdateNotSupportedByDriver("GIF");
         return nullptr;
     }
 

diff --git a/frmts/gif/gifdataset.cpp b/frmts/gif/gifdataset.cpp
@@ -161,9 +161,7 @@ GDALDataset *GIFDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The GIF driver does not support update access to existing"
-                 " files.");
+        ReportUpdateNotSupportedByDriver("GIF");
         return nullptr;
     }
 

diff --git a/frmts/grib/gribdataset.cpp b/frmts/grib/gribdataset.cpp
@@ -1485,9 +1485,7 @@ GDALDataset *GRIBDataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The GRIB driver does not support update access to existing "
-                 "datasets.");
+        ReportUpdateNotSupportedByDriver("GRIB");
         return nullptr;
     }
 

diff --git a/frmts/gxf/gxfdataset.cpp b/frmts/gxf/gxfdataset.cpp
@@ -279,9 +279,7 @@ GDALDataset *GXFDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         GXFClose(l_hGXF);
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The GXF driver does not support update access to existing"
-                 " datasets.");
+        ReportUpdateNotSupportedByDriver("GXF");
         return nullptr;
     }
 

diff --git a/frmts/hdf4/hdf4dataset.cpp b/frmts/hdf4/hdf4dataset.cpp
@@ -1274,9 +1274,7 @@ GDALDataset *HDF4Dataset::Open(GDALOpenInfo *poOpenInfo)
             delete poDS;
             CPLAcquireMutex(hHDF4Mutex, 1000.0);
 
-            CPLError(CE_Failure, CPLE_NotSupported,
-                     "The HDF4 driver does not support update access to "
-                     "existing datasets.");
+            ReportUpdateNotSupportedByDriver(HDF4_DRIVER_NAME);
             return nullptr;
         }
     }

diff --git a/frmts/hdf5/bagdataset.cpp b/frmts/hdf5/bagdataset.cpp
@@ -2621,8 +2621,7 @@ GDALDataset *BAGDataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The BAG driver does not support update access.");
+        ReportUpdateNotSupportedByDriver("BAG");
         return nullptr;
     }
 

diff --git a/frmts/hdf5/hdf5dataset.cpp b/frmts/hdf5/hdf5dataset.cpp
@@ -565,9 +565,7 @@ GDALDataset *HDF5Dataset::Open(GDALOpenInfo *poOpenInfo)
         if (poOpenInfo->eAccess == GA_Update)
         {
             delete poDS;
-            CPLError(CE_Failure, CPLE_NotSupported,
-                     "The HDF5 driver does not support update access to "
-                     "existing datasets.");
+            ReportUpdateNotSupportedByDriver("HDF5");
             return nullptr;
         }
     }

diff --git a/frmts/hdf5/hdf5imagedataset.cpp b/frmts/hdf5/hdf5imagedataset.cpp
@@ -971,9 +971,7 @@ GDALDataset *HDF5ImageDataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The HDF5ImageDataset driver does not support update access "
-                 "to existing datasets.");
+        ReportUpdateNotSupportedByDriver("HDF5");
         return nullptr;
     }
 

diff --git a/frmts/hdf5/s102dataset.cpp b/frmts/hdf5/s102dataset.cpp
@@ -146,8 +146,7 @@ GDALDataset *S102Dataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The S102 driver does not support update access.");
+        ReportUpdateNotSupportedByDriver("S102");
         return nullptr;
     }
 

diff --git a/frmts/hdf5/s104dataset.cpp b/frmts/hdf5/s104dataset.cpp
@@ -97,8 +97,7 @@ GDALDataset *S104Dataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The S104 driver does not support update access.");
+        ReportUpdateNotSupportedByDriver("S104");
         return nullptr;
     }
 

diff --git a/frmts/hdf5/s111dataset.cpp b/frmts/hdf5/s111dataset.cpp
@@ -103,8 +103,7 @@ GDALDataset *S111Dataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The S111 driver does not support update access.");
+        ReportUpdateNotSupportedByDriver("S111");
         return nullptr;
     }
 

diff --git a/frmts/iris/irisdataset.cpp b/frmts/iris/irisdataset.cpp
@@ -782,9 +782,7 @@ GDALDataset *IRISDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The IRIS driver does not support update access to existing"
-                 " datasets.");
+        ReportUpdateNotSupportedByDriver("IRIS");
         return nullptr;
     }
 

diff --git a/frmts/jaxapalsar/jaxapalsardataset.cpp b/frmts/jaxapalsar/jaxapalsardataset.cpp
@@ -567,10 +567,7 @@ GDALDataset *PALSARJaxaDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(
-            CE_Failure, CPLE_NotSupported,
-            "The JAXAPALSAR driver does not support update access to existing"
-            " datasets.\n");
+        ReportUpdateNotSupportedByDriver("JAXAPALSAR");
         return nullptr;
     }
 

diff --git a/frmts/jdem/jdemdataset.cpp b/frmts/jdem/jdemdataset.cpp
@@ -303,9 +303,7 @@ GDALDataset *JDEMDataset::Open(GDALOpenInfo *poOpenInfo)
     // Confirm the requested access is supported.
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The JDEM driver does not support update access to existing "
-                 "datasets.");
+        ReportUpdateNotSupportedByDriver("JDEM");
         return nullptr;
     }
 

diff --git a/frmts/jpeg/jpgdataset.cpp b/frmts/jpeg/jpgdataset.cpp
@@ -2762,9 +2762,7 @@ GDALDataset *JPGDatasetCommon::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The JPEG driver does not support update access to existing"
-                 " datasets.");
+        ReportUpdateNotSupportedByDriver("JPEG");
         return nullptr;
     }
 

diff --git a/frmts/l1b/l1bdataset.cpp b/frmts/l1b/l1bdataset.cpp
@@ -3330,9 +3330,7 @@ GDALDataset *L1BDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The L1B driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("L1B");
         if (fp != nullptr)
             CPL_IGNORE_RET_VAL(VSIFCloseL(fp));
         return nullptr;

diff --git a/frmts/map/mapdataset.cpp b/frmts/map/mapdataset.cpp
@@ -174,9 +174,7 @@ GDALDataset *MAPDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The MAP driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("MAP");
         return nullptr;
     }
 

diff --git a/frmts/msg/msgdataset.cpp b/frmts/msg/msgdataset.cpp
@@ -305,9 +305,7 @@ GDALDataset *MSGDataset::Open(GDALOpenInfo *poOpenInfo)
     if (poOpenInfo->eAccess == GA_Update)
     {
         delete poDS;
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The MSG driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("MSG");
         return nullptr;
     }
 

diff --git a/frmts/msgn/msgndataset.cpp b/frmts/msgn/msgndataset.cpp
@@ -451,9 +451,7 @@ GDALDataset *MSGNDataset::Open(GDALOpenInfo *poOpenInfo)
     /* -------------------------------------------------------------------- */
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "The MSGN driver does not support update access to existing"
-                 " datasets.\n");
+        ReportUpdateNotSupportedByDriver("MSGN");
         return nullptr;
     }
 

diff --git a/frmts/ngsgeoid/ngsgeoiddataset.cpp b/frmts/ngsgeoid/ngsgeoiddataset.cpp
@@ -313,10 +313,7 @@ GDALDataset *NGSGEOIDDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(
-            CE_Failure, CPLE_NotSupported,
-            "The NGSGEOID driver does not support update access to existing"
-            " datasets.\n");
+        ReportUpdateNotSupportedByDriver("NGSGEOID");
         return nullptr;
     }
 

diff --git a/frmts/nitf/ecrgtocdataset.cpp b/frmts/nitf/ecrgtocdataset.cpp
@@ -1036,8 +1036,7 @@ GDALDataset *ECRGTOCDataset::Open(GDALOpenInfo *poOpenInfo)
 
     if (poDS && poOpenInfo->eAccess == GA_Update)
     {
-        CPLError(CE_Failure, CPLE_NotSupported,
-                 "ECRGTOC driver does not support update mode");
+        ReportUpdateNotSupportedByDriver("ECRGTOC");
         delete poDS;
         return nullptr;
     }