STACIT: STAC 1.1 support #10773

m-mohr · 2024-09-11T21:15:39Z

What does this PR do?

Implement support for STAC 1.1 in STACIT driver.

Is waiting for #10721

Disclaimer: Last time I wrote C/C++ was 10 years ago, this may take me a while...

What are related issues/pull requests?

None

Tasklist

m-mohr · 2024-09-11T21:16:20Z

frmts/stacit/stacitdataset.cpp

@@ -139,8 +139,7 @@ int STACITDataset::Identify(GDALOpenInfo *poOpenInfo)
            return pszHeader[0] == '{';
        }

-        if (strstr(pszHeader, "\"stac_version\"") != nullptr &&
-            strstr(pszHeader, "\"proj:transform\"") != nullptr)


Why is proj:transform checked for? It could appear both in properties or assets so it seems like this check may lead to false results.

The driver requires the projection extension to be there, hence checking for it. And as Identify() needs to be quick (it only has a subset of the JSON and can't use a JSON parser), it doesn't get into the details to figure out where the element is present

Oh, now I remember what strstr does. I'll revert, thanks.

It needs two out of the three proj: properties and transform is one them. So just checking proj:transform seems to exclude cases where proj:bbox and proj:shape are set. Should we update this to check whether one of proj:transform or proj:bbox is present? That should capture all three cases.

fields currently new

transform + shape accepted accepted

transform + bbox accepted accepted

bbox + shape rejected accepted

Maybe worth a separate small PR though, it's unrelated to the STAC 1.1 updates.

Maybe worth a separate small PR though, it's unrelated to the STAC 1.1 updates.

yes

taken into account per 8dd8c81

m-mohr · 2024-09-11T21:18:09Z

frmts/stacit/stacitdataset.cpp

-                else if (osCommonName == "alpha")
-                    poVRTBand->SetColorInterpretation(GCI_AlphaBand);


There is no common name called 'alpha" in STAC, thus removing.

Really ? but please don't remove that there, otherwise this is going to conflict with PR #10721 that touches that code too

Yes, no alpha. The full list of allowed values is here: https://github.com/stac-extensions/eo?tab=readme-ov-file#common-band-names
So that code should never get executed.

The list was also extended a bit recently and the property in STAC 1.1 is a named eo:common_name and can be placed in asset or bands. So I guess we need to do more updates in Gdal, including #10721

The list was also extended a bit recently

yes, #10721 takes inspiration from it, but feedback of the GDAL community was that some of the details like "rededge071", "rededge075", etc. were much too specific, so we didn't go to that detail for the GCI_ColorInterpretation enumeration.

I'm wondering if #10721 shouldn't be merge first (should be soon. I'm just letting a couple extra days for potential new comments on it), so that you can work on a stable base

Yeah, go ahead. I can wait for that. This PR will still take me a little longer anyway.

frmts/stacit/stacitdataset.cpp

Co-authored-by: Even Rouault <even.rouault@spatialys.com>

coveralls · 2024-09-11T23:20:18Z

coverage: 69.363% (+0.004%) from 69.359%
when pulling 166d5b3 on m-mohr:stac-1.1
into 5999d8b on OSGeo:master.

rouault · 2024-09-19T16:47:05Z

#10721 has been merged. Please rebase on top of latest master

github-actions · 2024-10-18T02:48:10Z

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular link
to any issues which this pull request fixes
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in 2 weeks.

m-mohr · 2024-10-18T10:18:12Z

Won't have time to work on this before December, but happy to reopen a new PR if this gets closed...

github-actions · 2024-11-16T02:47:34Z

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular link
to any issues which this pull request fixes
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in 2 weeks.

m-mohr · 2024-11-16T13:07:04Z

Still not December ;)

github-actions · 2024-12-15T02:58:39Z

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular link
to any issues which this pull request fixes
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in 2 weeks.

m-mohr · 2024-12-18T23:04:06Z

Closing for now, was a bit too optimistic about my time. If no one else works on it I may pick it up again at some point, others feel free to continue with the given code or start from scratch.

rouault · 2025-01-30T11:03:11Z

continued in #11760

m-mohr commented Sep 11, 2024

View reviewed changes

m-mohr force-pushed the stac-1.1 branch from 962b935 to c128125 Compare September 11, 2024 21:20

STACIT: STAC 1.1 support

3b6cf04

m-mohr force-pushed the stac-1.1 branch from c128125 to 3b6cf04 Compare September 11, 2024 21:23

m-mohr changed the title ~~First attempt for STAC 1.1 support~~ STACIT: STAC 1.1 support Sep 11, 2024

rouault reviewed Sep 11, 2024

View reviewed changes

frmts/stacit/stacitdataset.cpp Outdated Show resolved Hide resolved

Update frmts/stacit/stacitdataset.cpp

61cdf18

Co-authored-by: Even Rouault <even.rouault@spatialys.com>

lint and improve detection

166d5b3

github-actions bot added the stale label Oct 18, 2024

stale bot removed the stale label Oct 18, 2024

github-actions bot added the stale label Nov 16, 2024

stale bot removed the stale label Nov 16, 2024

github-actions bot added the stale label Dec 15, 2024

scottyhq mentioned this pull request Dec 18, 2024

Make CRS parsing of GTI:index.parquet consistent with STACIT:items.json #11512

Closed

m-mohr closed this Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STACIT: STAC 1.1 support #10773

STACIT: STAC 1.1 support #10773

m-mohr commented Sep 11, 2024 •

edited

Loading

m-mohr Sep 11, 2024

rouault Sep 11, 2024

m-mohr Sep 11, 2024

m-mohr Sep 12, 2024 •

edited

Loading

rouault Sep 12, 2024

rouault Jan 30, 2025

m-mohr Sep 11, 2024 •

edited

Loading

rouault Sep 11, 2024

m-mohr Sep 11, 2024 •

edited

Loading

m-mohr Sep 11, 2024 •

edited

Loading

rouault Sep 11, 2024

m-mohr Sep 11, 2024 •

edited

Loading

coveralls commented Sep 11, 2024 •

edited

Loading

rouault commented Sep 19, 2024

github-actions bot commented Oct 18, 2024

m-mohr commented Oct 18, 2024

github-actions bot commented Nov 16, 2024

m-mohr commented Nov 16, 2024

github-actions bot commented Dec 15, 2024

m-mohr commented Dec 18, 2024

rouault commented Jan 30, 2025

fields	currently	new
transform + shape	accepted	accepted
transform + bbox	accepted	accepted
bbox + shape	rejected	accepted

		else if (osCommonName == "alpha")
		poVRTBand->SetColorInterpretation(GCI_AlphaBand);

STACIT: STAC 1.1 support #10773

STACIT: STAC 1.1 support #10773

Conversation

m-mohr commented Sep 11, 2024 • edited Loading

What does this PR do?

What are related issues/pull requests?

Tasklist

m-mohr Sep 11, 2024

Choose a reason for hiding this comment

rouault Sep 11, 2024

Choose a reason for hiding this comment

m-mohr Sep 11, 2024

Choose a reason for hiding this comment

m-mohr Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

rouault Sep 12, 2024

Choose a reason for hiding this comment

rouault Jan 30, 2025

Choose a reason for hiding this comment

m-mohr Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

rouault Sep 11, 2024

Choose a reason for hiding this comment

m-mohr Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

m-mohr Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

rouault Sep 11, 2024

Choose a reason for hiding this comment

m-mohr Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

coveralls commented Sep 11, 2024 • edited Loading

rouault commented Sep 19, 2024

github-actions bot commented Oct 18, 2024

m-mohr commented Oct 18, 2024

github-actions bot commented Nov 16, 2024

m-mohr commented Nov 16, 2024

github-actions bot commented Dec 15, 2024

m-mohr commented Dec 18, 2024

rouault commented Jan 30, 2025

m-mohr commented Sep 11, 2024 •

edited

Loading

m-mohr Sep 12, 2024 •

edited

Loading

m-mohr Sep 11, 2024 •

edited

Loading

m-mohr Sep 11, 2024 •

edited

Loading

m-mohr Sep 11, 2024 •

edited

Loading

m-mohr Sep 11, 2024 •

edited

Loading

coveralls commented Sep 11, 2024 •

edited

Loading