[GPKG] Fix crash in GPKG rollback after PR #11609 #11680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully Fix OSGeo#11679 Take care of syncing the array of generated columns when rolling back.
rouault
reviewed
Jan 17, 2025
| { | ||
| } | ||
|
|
||
| std::unique_ptr<T> poFieldDefn; | ||
| int iField; | ||
| FieldChangeType eChangeType; | ||
| // Used by drivers (GPKG) to track generated fields | ||
| bool bGenerated; |
There was a problem hiding this comment.
Just thinking that it could be perhaps worthwhile to have the generated boolean in OGRFieldDefn itself (could apply to other drivers), but that's likely out of scope of this PR / work ?
There was a problem hiding this comment.
I agree it could be better moved to OGRFieldDefn but I'd prefer to do it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully Fix #11679
Take care of syncing the array of generated
columns when rolling back.
I've made PrepareStartTransaction and FinishRollbackTransaction virtual for consistency with other methods of the same base class because I can foresee cases were we will need to override.