Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MultiPoints in DXF writer (fixes #11686) #11687

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

michkowalczuk
Copy link
Contributor

@michkowalczuk michkowalczuk commented Jan 17, 2025

What does this PR do?

Adds support for writing MultiPoints by DXF driver.
#11686

What are related issues/pull requests?

It comes from this thread.

Tasklist

  • ADD YOUR TASKS HERE
  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Add test case(s)
  • Add documentation
  • Updated Python API documentation (swig/include/python/docs/)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS:
  • Compiler:

@michkowalczuk michkowalczuk changed the title Handle MultiPoints in DXF writer #11686 Handle MultiPoints in DXF writer (fixes #11686) Jan 17, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 18, 2025

Coverage Status

coverage: 70.06% (-0.003%) from 70.063%
when pulling e1b5dd3 on michkowalczuk:handle-MultiPoints-in-DXF-writer
into 3da6544 on OSGeo:master.

@rouault
Copy link
Member

rouault commented Jan 18, 2025

CC @atlight . Looks reasonable to me. A new autotest could be appropriate, but I could live without it too here.

@michkowalczuk
Copy link
Contributor Author

CC @atlight . Looks reasonable to me. A new autotest could be appropriate, but I could live without it too here.

@rouault Can I just update "test_ogr_dxf_12" test function in ogr_dxf.py? Or create a new test definition?

@atlight atlight self-requested a review January 20, 2025 08:31
@rouault
Copy link
Member

rouault commented Jan 20, 2025

Can I just update "test_ogr_dxf_12" test function in ogr_dxf.py? Or create a new test definition?

that would be fine. Change the comment of the test to "Write a simple file with a few geometries of different types, and read back"

@rouault rouault added this to the 3.11.0 milestone Jan 21, 2025
@rouault rouault marked this pull request as ready for review January 21, 2025 00:50
@rouault rouault merged commit 63cd33a into OSGeo:master Jan 21, 2025
37 of 38 checks passed
@michkowalczuk michkowalczuk deleted the handle-MultiPoints-in-DXF-writer branch January 23, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants