r.mapcalc: deprecate -s flag, use autoseeding by default #6742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
nilason
reviewed
Dec 16, 2025
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
I only have some minor mainly stylistic suggestions (please discard what you disagree with).
Contributor
Author
Thanks, fixed! |
echoix
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in #6717 where we decided to implement default autoseeding in r.mapcalc, so that you don't have to always use -s flag.
It turned out somewhat more complicated due to the need to disable parallelization when using rand(), before we would disable it based on using -s of seed parameter, but whit -s removed, it needs to be decided based on whether the expression contains "rand function". So this solution finds out whether the rand function is used and then creates the seed and disables parallelization. The
has_rand_exprwas written by AI but I tested it quite a bit.I adjusted all the cases I could find using -s flag with rand(), mostly in tests and GUI. The wrapper will be adjusted in #6717.