-
-
Notifications
You must be signed in to change notification settings - Fork 396
v.profile: Add JSON output format #6875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, please read our contributing guidelines, specifically pre-commit to get the formatting correct.
|
I've addressed your feedback:
Please review the updated Thanks! |
Please keep the plain mode there for backwards compatibility with | as separator and CSV needs to have comma. All I was trying to avoid is too much code duplication. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@petrasovaa
The separator logic respects user overrides via the Let me know if you'd like any adjustments! |
Fixes #6232
Problem Description
The
v.profilemodule only supported plain text output with pipe-delimited or custom separators. We were required to add JSON support as well.Solution
Implemented comprehensive output format support with three options:
Plain format (default): Traditional CSV-style output with quoted string values. Maintains full backward compatibility with existing scripts.
CSV format: Unquoted delimiter-separated values optimized for spreadsheet applications. Uses the same separator parameter as plain format but omits quotes for cleaner parsing.
JSON format: Structured output with proper data type handling. Each feature is represented as a JSON object containing:
category: Feature category number (always present, even without database)distance: Distance along profile lineattributesImplementation details:
G_json_*functions) for JSON serialization with proper NULL value handlingG_warning()for database operation failuresTesting
Automated Tests (test_v_profile.py):
Added
testJsonFormat()that validates:All 6 test suite tests pass, including the new JSON format test.
Manual Testing with NC Basic dataset:
JSON Output example :-
[ { "category": 572, "distance": 19537.972502200733, "attributes": { "cat": 572, "feature_id": "986138", "featurenam": "Greshams Lake", "class": "Reservoir", ... } } ]