chromium: Remove defunct LLVM version check logic #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new core LLVM support lacks an equivalent of LLVMVERSION as exposed
by meta-clang, resulting in this benign WARNING:
WARNING: mc:house:chromium-ozone-wayland-140.0.7339.136-r0 do_check_llvm_version: Unable to determine LLVM version. Chromium may not be compiled successfully if the LLVM version is below 14.0.0.
LLVM-14 was released nearly four years ago. Upstream chromium's current
policy is summarized here:
https://chromium.googlesource.com/chromium/src/+/main/docs/toolchain_support.md
...and quoting the releavant portion:
Even within clang/libc++, we often rely on recent bugfixes and
feature additions, so generally only the most recent LLVM version
is supported.
Silence the warning by dropping the bitrotted version enforement logic.
Signed-off-by: Calvin Owens <calvin@wbinvd.org>
|
The warning shows up after #923 but this change doesn't actually depend on that PR. If you'd rather keep the version check in some form just say the word and I'll do that instead. |
|
This also fixes #875 |
jcalvinowens
added a commit
to jcalvinowens/meta-browser
that referenced
this pull request
Sep 28, 2025
|
@kraj can you PTAL? |
jcalvinowens
added a commit
to jcalvinowens/meta-browser
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new core LLVM support lacks an equivalent of LLVMVERSION as exposed by meta-clang, resulting in this benign WARNING:
LLVM-14 was released nearly four years ago. Upstream chromium's current policy is summarized here:
...and quoting the releavant portion:
Silence the warning by dropping the bitrotted version enforement logic.