Skip to content

Conversation

@MigrainePanda
Copy link
Contributor

@MigrainePanda MigrainePanda commented Nov 18, 2025

Pull Request Template

Description

Tested on fork, all workflows pass. Does not make logic changes, only changes styling. Uses prettier --write ..

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@MigrainePanda MigrainePanda self-assigned this Nov 18, 2025
@MigrainePanda MigrainePanda added the development Updates and modifications to development/deployment tools label Nov 18, 2025
@MigrainePanda MigrainePanda requested review from a team as code owners November 18, 2025 01:17
@MigrainePanda MigrainePanda moved this from Backlog to In Progress in classroom-polling Nov 18, 2025
LaserBread
LaserBread previously approved these changes Nov 19, 2025
Copy link
Contributor

@LaserBread LaserBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like everything works, and that's good. I'll give it the pass, but I think you should put in the README.md instructions on using Prettify or installing it.

@MigrainePanda MigrainePanda added this pull request to the merge queue Nov 19, 2025
@MigrainePanda MigrainePanda removed this pull request from the merge queue due to a manual request Nov 19, 2025
@MigrainePanda
Copy link
Contributor Author

@LaserBread added a mention in documentation

@LaserBread LaserBread self-requested a review November 20, 2025 00:57
Copy link
Contributor

@LaserBread LaserBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@LaserBread
Copy link
Contributor

I'll approve the merge, but it looks like you can also make Prettier auto-format your changes when you commit, and that might be worth looking into since it will be much faster than running the prettier command on the entire repo.

@MigrainePanda
Copy link
Contributor Author

Previous PR #343 already implemented that

@MigrainePanda MigrainePanda added this pull request to the merge queue Nov 20, 2025
Merged via the queue into OSU-MC:development with commit 22ab52b Nov 20, 2025
8 checks passed
@MigrainePanda MigrainePanda deleted the format-repo branch November 20, 2025 01:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in classroom-polling Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Updates and modifications to development/deployment tools

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants