-
Notifications
You must be signed in to change notification settings - Fork 5
Format all code in repository #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LaserBread
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like everything works, and that's good. I'll give it the pass, but I think you should put in the README.md instructions on using Prettify or installing it.
|
@LaserBread added a mention in documentation |
LaserBread
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
|
I'll approve the merge, but it looks like you can also make Prettier auto-format your changes when you commit, and that might be worth looking into since it will be much faster than running the prettier command on the entire repo. |
|
Previous PR #343 already implemented that |
Pull Request Template
Description
Tested on fork, all workflows pass. Does not make logic changes, only changes styling. Uses
prettier --write ..Checklist:
Before you submit your Pull Request, please make sure you have completed the following tasks: