-
Notifications
You must be signed in to change notification settings - Fork 5
Deleted a duplicate login page #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nvalid "copy" command is replaced with "cp".
Added a sitemap that can be opened with draw.io.
MigrainePanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted file is fine, but you are trying to merge 8 commits into OSU-MC:development, which includes some of the previous commits you have already merged. You should sync your fork to the repo, so the PR only merges the 1 (or more) new commits.
Wouldn't it not sync those changes automatically? I have synced the repo multiple times, and it still thinks those 8 commits need to be merged into the repo. |
…into development
|
Trying to redo the PR |
Description
The repository has two login pages, one in ./client/src and one in ./client/src/pages. It seems deleting the one in ./client/src has no negative side effects when deleted, while the one in ./client/src/pages makes the app unable to build. I will see if the tests pan out.
Fixes #356
Fixes #357
Additional Information
Checklist:
Before you submit your Pull Request, please make sure you have completed the following tasks: