Skip to content

Conversation

@LaserBread
Copy link
Contributor

Pull Request Template

Description

Created Jest test cases for the password_gen.js file, mostly so I could test my Jest skills.

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@LaserBread LaserBread requested a review from a team as a code owner November 23, 2025 21:03
@LaserBread LaserBread added development Updates and modifications to development/deployment tools javascript Pull requests that update javascript code labels Nov 23, 2025
@LaserBread LaserBread enabled auto-merge November 23, 2025 21:03
Copy link
Contributor

@MigrainePanda MigrainePanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generateOTP() doesn't type check for int but isn't a problem for this PR. Looks good

@LaserBread LaserBread added this pull request to the merge queue Nov 27, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in classroom-polling Nov 27, 2025
Merged via the queue into OSU-MC:development with commit a3c98c8 Nov 27, 2025
8 checks passed
@LaserBread LaserBread deleted the passw branch November 27, 2025 23:22
@github-project-automation github-project-automation bot moved this from In Progress to Done in classroom-polling Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Updates and modifications to development/deployment tools javascript Pull requests that update javascript code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants