Skip to content

Conversation

@MigrainePanda
Copy link
Contributor

Pull Request

Description

Updates CORS options on core and socket servers to include more methods and the necessary origins.

Fixes #354

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@MigrainePanda MigrainePanda self-assigned this Dec 5, 2025
@MigrainePanda MigrainePanda requested review from a team as code owners December 5, 2025 07:52
@MigrainePanda MigrainePanda added the development Updates and modifications to development/deployment tools label Dec 5, 2025
Copy link

@thaivinhle thaivinhle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks like a solid fix for the CORS methods on both core and socket servers. Thanks!

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in classroom-polling Dec 8, 2025
@MigrainePanda MigrainePanda added this pull request to the merge queue Dec 8, 2025
Merged via the queue into OSU-MC:development with commit 5091151 Dec 8, 2025
8 checks passed
@MigrainePanda MigrainePanda deleted the cors branch December 8, 2025 07:33
@github-project-automation github-project-automation bot moved this from In Progress to Done in classroom-polling Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Updates and modifications to development/deployment tools

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Leftover TODO: set up config for stuff like CORS: apiUtil.js

2 participants