feat: add serviceMonitor.extraLabels support #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated version and appVersion for redis, redis-cluster, redis-replication, and redis-sentinel charts to 0.16.5, 0.16.7, and 0.16.9 respectively. - Introduced `serviceMonitor.extraLabels` in values.yaml and README.md for all Redis charts, allowing users to add custom labels to the ServiceMonitor when enabled. - Updated templates to utilize the new `extraLabels` configuration for ServiceMonitor. This change enhances the flexibility of monitoring configurations for Redis deployments. Signed-off-by: drivebyer <wuyangmuc@gmail.com>
drivebyer
requested review from
shubham-cmyk and
iamabhishek-dubey
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
==========================================
- Coverage 30.20% 29.84% -0.36%
==========================================
Files 55 57 +2
Lines 6294 6601 +307
==========================================
+ Hits 1901 1970 +69
- Misses 4200 4445 +245
+ Partials 193 186 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serviceMonitor.extraLabelsin values.yaml and README.md for all Redis charts, allowing users to add custom labels to the ServiceMonitor when enabled.extraLabelsconfiguration for ServiceMonitor.This change enhances the flexibility of monitoring configurations for Redis deployments.
Description
Fixes #1187
Type of change
Checklist
Additional Context