Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add securityContext config in chart for redis-exporter #1238

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Hexoplon
Copy link
Contributor

@Hexoplon Hexoplon commented Feb 9, 2025

Description

Add ability to configure securityContext for redis-exporter in redis helm charts:

  • redis
  • redis-cluster
  • redis-replication
  • redis-sentinel

Supported in:

  • v1beta1 & v1beta2: Redis, RedisCluster, RedisReplication Operator CRDs
  • v1beta2 only: RedisSentinel Operator CRD

This aligns with existing redis operator CRD functionality.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

This change is required to support restricted pod security admission standards for the redis-exporter containers.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.00%. Comparing base (60ef5a2) to head (d137b1f).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   30.20%   29.00%   -1.21%     
==========================================
  Files          55       58       +3     
  Lines        6294     6693     +399     
==========================================
+ Hits         1901     1941      +40     
- Misses       4200     4589     +389     
+ Partials      193      163      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

charts/redis-cluster/README.md Outdated Show resolved Hide resolved
Add ability to configure securityContext for redis-exporter in redis helm charts:
- redis
- redis-cluster
- redis-replication
- redis-sentinel

Supported in:
- v1beta1 & v1beta2: Redis, RedisCluster, RedisReplication Operator CRDs
- v1beta2 only: RedisSentinel Operator CRD

This aligns with existing redis operator CRD functionality.

Signed-off-by: Hexoplon <github@zackeus.no>
@drivebyer drivebyer changed the title feat: add securityContext config for redis-exporter feat: add securityContext config in chart for redis-exporter Feb 11, 2025
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit 9dbec50 into OT-CONTAINER-KIT:master Feb 11, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants