Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make recreate statefulset only trigger when value true #1240

Merged

Conversation

husnialhamdani
Copy link
Contributor

Description

Make recreate statefulset only trigger when value true

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
@husnialhamdani husnialhamdani force-pushed the fix-annotations-recreate-sts branch from 955a338 to 7c811e4 Compare February 12, 2025 21:48
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.00%. Comparing base (60ef5a2) to head (7c811e4).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/redis-cluster.go 0.00% 0 Missing and 1 partial ⚠️
pkg/k8sutils/redis-replication.go 0.00% 0 Missing and 1 partial ⚠️
pkg/k8sutils/redis-sentinel.go 0.00% 0 Missing and 1 partial ⚠️
pkg/k8sutils/redis-standalone.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   30.20%   29.00%   -1.21%     
==========================================
  Files          55       58       +3     
  Lines        6294     6693     +399     
==========================================
+ Hits         1901     1941      +40     
- Misses       4200     4589     +389     
+ Partials      193      163      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit 4256fd3 into OT-CONTAINER-KIT:master Feb 13, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants