feat: verify codgen in Makefile and Github workflow #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-cmyk
changed the title
shubham-cmyk
changed the title
shubham-cmyk
force-pushed
the
verify-gen
branch
from
0493b8f to
3096d22
Compare
|
@drivebyer Can you check this? This seems to be important to me since the last time in the API change you didn't pushed deep copy out there, which has caused issues. Now we could make sure user has to push the required code-gen |
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk
force-pushed
the
verify-gen
branch
from
3096d22 to
f7e4819
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
LGTM, it's nice! |
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
…#673) * fixing workflow Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * verify Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * fix version in makefile Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify that the proper code generation is happening or not.
Fixing the Improper variable name in the workflow.
Now we could use
make codegen- To generate crd + deepcopymake verify-codegen- To verify if we have any any missing crd ( any other manifests ) or deepcopy