Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify k8s version which contain darwin arm64 #719

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

drivebyer
Copy link
Collaborator

Description

Fix when execute make test on darwin arm64:

➜  redis-operator-1 git:(master) make test
/Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
/Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
mkdir -p /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin
test -f /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin/setup-envtest.sh || curl -sSLo /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.7.0/hack/setup-envtest.sh
source /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin/setup-envtest.sh; fetch_envtest_tools /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin; setup_envtest_env /Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin; go test ./... -coverprofile cover.out
fetching envtest tools@1.19.2 (into '/Users/wuyang/workspace/github.com/drivebyer/redis-operator-1/testbin')
tar: Error opening archive: Unrecognized archive format
make: *** [test] Error 1
➜  redis-operator-1 git:(test-version) cat /tmp/kubebuilder-tools-1.19.2-darwin-arm64.tar.gz 
<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubebuilder-tools/kubebuilder-tools-1.19.2-darwin-arm64.tar.gz</Details></Error>% 

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer enabled auto-merge (squash) December 7, 2023 07:00
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7692708) 27.79% compared to head (d90729a) 27.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   27.79%   27.79%           
=======================================
  Files          18       18           
  Lines        3123     3123           
=======================================
  Hits          868      868           
  Misses       2228     2228           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 48add7e into OT-CONTAINER-KIT:master Dec 7, 2023
21 checks passed
@drivebyer drivebyer deleted the test-version branch December 7, 2023 07:20
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
…#719)

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants