Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis cluster update as scale out #872

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Fix redis cluster status not updated when scale out cluster size.

more: it's ok about to remove the statefulset assert step && ping pod step. We can test these only by redis cluster status

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer added the bug Something isn't working label Apr 14, 2024
@drivebyer drivebyer requested a review from shubham-cmyk April 14, 2024 10:07
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 38.70%. Comparing base (d121d86) to head (068d5a3).
Report is 24 commits behind head on master.

Files Patch % Lines
controllers/rediscluster_controller.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
+ Coverage   35.20%   38.70%   +3.50%     
==========================================
  Files          19       19              
  Lines        3213     2656     -557     
==========================================
- Hits         1131     1028     -103     
+ Misses       2015     1559     -456     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer enabled auto-merge (squash) April 16, 2024 05:55
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@drivebyer drivebyer merged commit 80e7f2f into OT-CONTAINER-KIT:master Apr 16, 2024
29 checks passed
@drivebyer drivebyer deleted the fix-scalingup-status branch April 16, 2024 13:50
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* fix: redis cluster update as scale out

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* add e2e test step && remove unnecessary test assert

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* add newline

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

* add newline

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

---------

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants