Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: probe use built-in, discarded healthcheck.sh #907

Merged
merged 2 commits into from
May 6, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

#443, #766

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 39.75%. Comparing base (d121d86) to head (b43c471).
Report is 36 commits behind head on master.

❗ Current head b43c471 differs from pull request most recent head 700b8dd. Consider uploading reports for the commit 700b8dd to get more accurate results

Files Patch % Lines
k8sutils/statefulset.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   35.20%   39.75%   +4.55%     
==========================================
  Files          19       19              
  Lines        3213     2674     -539     
==========================================
- Hits         1131     1063      -68     
+ Misses       2015     1540     -475     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer added the enhancement New feature or request label Apr 30, 2024
Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer enabled auto-merge (squash) May 4, 2024 05:04
@drivebyer drivebyer requested a review from shubham-cmyk May 4, 2024 05:05
@drivebyer drivebyer disabled auto-merge May 6, 2024 06:45
@drivebyer drivebyer enabled auto-merge (squash) May 6, 2024 06:45
@drivebyer drivebyer merged commit 4e60683 into OT-CONTAINER-KIT:master May 6, 2024
27 checks passed
@drivebyer drivebyer deleted the redis-probe branch May 9, 2024 06:49
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
)

* feat: probe use built-in, discarded healthcheck.sh

Signed-off-by: drivebyer <yang.wu@daocloud.io>

* use shell

Signed-off-by: drivebyer <yang.wu@daocloud.io>

---------

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants