fix: sentinel should not reconcile until replication cluster ready #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
==========================================
+ Coverage 35.20% 40.98% +5.78%
==========================================
Files 19 20 +1
Lines 3213 2674 -539
==========================================
- Hits 1131 1096 -35
+ Misses 2015 1505 -510
- Partials 67 73 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
…T-CONTAINER-KIT#964) * fix: sentinel should not reconcile until replication cluster ready Signed-off-by: drivebyer <wuyangmuc@gmail.com> * check master attached slave Signed-off-by: drivebyer <wuyangmuc@gmail.com> * increase waiting Signed-off-by: drivebyer <wuyangmuc@gmail.com> --------- Signed-off-by: drivebyer <wuyangmuc@gmail.com> Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #522
Type of change
Checklist
Additional Context