Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add common controller util #977

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

drivebyer
Copy link
Collaborator

No description provided.

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 45 lines in your changes missing coverage. Please review.

Project coverage is 40.75%. Comparing base (d121d86) to head (c9c9d52).
Report is 67 commits behind head on master.

Files Patch % Lines
controllers/rediscluster_controller.go 11.53% 23 Missing ⚠️
controllers/redisreplication_controller.go 23.07% 10 Missing ⚠️
controllers/redissentinel_controller.go 30.00% 7 Missing ⚠️
controllers/redis_controller.go 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   35.20%   40.75%   +5.55%     
==========================================
  Files          19       20       +1     
  Lines        3213     2682     -531     
==========================================
- Hits         1131     1093      -38     
+ Misses       2015     1518     -497     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit b44f303 into OT-CONTAINER-KIT:master Jun 8, 2024
28 of 29 checks passed
@drivebyer drivebyer deleted the add-utils branch June 8, 2024 03:52
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* refactor: add common controller util

Signed-off-by: drivebyer <yang.wu@daocloud.io>

* fix lint

Signed-off-by: drivebyer <wuyangmuc@gmail.com>

---------

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant