Nida #2
Nida #2
Conversation
| filters: | ||
| "tag:Name": "loki" |
There was a problem hiding this comment.
Also add tags for promtails so that we can install promtail agent on all VMs where every required
There was a problem hiding this comment.
also add keygroups in dynamic inventory and make sure we make use of private IP to list the instance using dynamic inventory.
| [defaults] | ||
| inventory = aws_ec2.yml # Path to your inventory file | ||
| host_key_checking = False # Optional: disable host key checking for SSH | ||
| remote_user = ubuntu # Default user for SSH connections |
There was a problem hiding this comment.
No need to degine the remote_user as ubuntu as we are going to use the same role to redhat and centos as well. So default user name will change
loki_role/README.md
Outdated
loki_role/meta/main.yml
Outdated
There was a problem hiding this comment.
if meta.yml is not required then delete it
| - name: Install prerequisite packages on Debian-based systems | ||
| ansible.builtin.apt: | ||
| name: | ||
| - gnupg | ||
| - curl | ||
| state: present | ||
| when: ansible_facts['os_family'] == 'Debian' |
There was a problem hiding this comment.
As we discussed earlier as well variables the package name don't hardcode it inside the role
|
|
||
| - name: Add Grafana GPG key on Debian-based systems | ||
| ansible.builtin.apt_key: | ||
| url: https://packages.grafana.com/gpg.key |
There was a problem hiding this comment.
this url should be also be variablised
|
|
||
| - name: Add Grafana repository on Debian-based systems | ||
| ansible.builtin.apt_repository: | ||
| repo: "deb https://packages.grafana.com/oss/deb stable main" |
| state: present | ||
| when: ansible_facts['os_family'] == 'Debian' | ||
|
|
||
| - name: Update apt package repository on Debian-based systems |
There was a problem hiding this comment.
can't we do update cache and install grafana in single. Command I think it is achievable please look into this
| - name: Install prerequisite packages on Red Hat-based systems | ||
| ansible.builtin.yum: | ||
| name: | ||
| - gnupg | ||
| - curl | ||
| state: present | ||
| when: ansible_facts['os_family'] == 'RedHat' |
There was a problem hiding this comment.
Variables the package name inside the vars.yml shouldn't be hardcoded
| - name: Add Grafana GPG key on Red Hat-based systems | ||
| ansible.builtin.rpm_key: | ||
| state: present | ||
| key: https://packages.grafana.com/gpg.key |
| - name: Add Grafana repository on Red Hat-based systems | ||
| ansible.builtin.yum_repository: | ||
| name: grafana | ||
| description: Grafana OSS Repository | ||
| baseurl: https://packages.grafana.com/oss/rpm | ||
| gpgcheck: 1 | ||
| gpgkey: https://packages.grafana.com/gpg.key | ||
| enabled: 1 | ||
| when: ansible_facts['os_family'] == 'RedHat' | ||
|
|
||
| - name: Install Grafana on Red Hat-based systems | ||
| ansible.builtin.yum: | ||
| name: grafana | ||
| state: present | ||
| when: ansible_facts['os_family'] == 'RedHat' | ||
| notify: starting grafana |
There was a problem hiding this comment.
variabilize the package name nothing should be hard coded inside the tasks.
| - name: Install unzip, bzip2, xz-utils, and zstd | ||
| ansible.builtin.apt: | ||
| name: | ||
| - unzip | ||
| - bzip2 | ||
| - xz-utils | ||
| - zstd | ||
| state: present |
|
|
||
| - name: Add the user 'loki' | ||
| ansible.builtin.user: | ||
| name: loki |
There was a problem hiding this comment.
username should also be variabilized
| - name: Creating directory for config file | ||
| ansible.builtin.file: | ||
| path: "{{ item }}" | ||
| state: directory | ||
| owner: loki | ||
| group: loki | ||
| mode: '755' | ||
| recurse: true | ||
| loop: | ||
| - /etc/loki/logs | ||
| - /data/loki |
There was a problem hiding this comment.
this directory path should also be define in vars.yml
| - name: Creating Config file | ||
| ansible.builtin.file: | ||
| path: /etc/loki/loki-local-config.yaml | ||
| state: touch |
There was a problem hiding this comment.
This file should also be not created as we are going to copy it from our ansible controller to slave. So doesn't requires to create it
| - name: Copying the config file content | ||
| ansible.builtin.template: | ||
| src: templates/loki-config.j2 | ||
| dest: /etc/loki/loki-local-config.yaml |
There was a problem hiding this comment.
Have we tested this if it is working fine or not. I think you haven't add values to jinja template till now directly copy pasting the jinja template.
| - name: Creating service file | ||
| ansible.builtin.file: | ||
| path: /etc/systemd/system/loki.service | ||
| state: touch |
There was a problem hiding this comment.
Same here not required to create a file
| - name: Include grafana tasks | ||
| ansible.builtin.include_tasks: | ||
| file: grafana.yaml | ||
| when: run_grafana_tasks |
There was a problem hiding this comment.
change it to something like
install_grafana == true
| - name: Include Loki tasks | ||
| ansible.builtin.include_tasks: | ||
| file: loki.yaml | ||
| when: run_loki_tasks |
| - name: Include promtail tasks | ||
| ansible.builtin.include_tasks: | ||
| file: promtail.yml | ||
| when: run_promtail_tasks |
| - name: Install prerequisite packages | ||
| package: | ||
| name: | ||
| - unzip | ||
| state: present | ||
| when: ansible_facts['os_family'] in ['Debian', 'RedHat'] |
| - name: Move Promtail binary to /usr/local/bin | ||
| ansible.builtin.command: | ||
| cmd: mv /usr/local/bin/promtail-linux-amd64 /usr/local/bin/promtail |
There was a problem hiding this comment.
can't we do it using ansible builtin module
| - name: Reload systemd daemon | ||
| ansible.builtin.systemd: | ||
| daemon_reload: true | ||
|
|
| - name: Check Promtail service status | ||
| ansible.builtin.command: | ||
| cmd: systemctl status promtail.service | ||
| register: promtail_status | ||
| changed_when: false | ||
|
|
There was a problem hiding this comment.
insight of this make use of molecule test cases to test ansible role
changes added