-
-
Notifications
You must be signed in to change notification settings - Fork 225
Comprehensive Newsletter functionality #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsu-ki
wants to merge
14
commits into
OWASP-BLT:main
Choose a base branch
from
tsu-ki:newsletter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b8976d1
initial commit
tsu-ki 30d2a16
resolving coderabbit suggestions
tsu-ki 35ebc9f
fixing codeRabbit stuff
tsu-ki 33d54ee
Merge branch 'main' into newsletter
tsu-ki 2d0a93a
resolving codeRabbit suggestions
tsu-ki 99b0dd4
resolving codeRabbit suggestions
tsu-ki 36a2442
fixing security bugs
tsu-ki 690c607
removed dependencies
tsu-ki 7371d8a
added poetry lock file
tsu-ki 83f9570
fixing failing tests
tsu-ki 8e70de1
Delete website/migrations/0231_newsletter_newslettersubscriber.py
tsu-ki 7c87d67
Delete website/migrations/0232_newslettersubscriber_token_created_at.py
tsu-ki 40c14bd
fix
tsu-ki 803feff
pre-commit fix
tsu-ki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
import logging | ||
|
||
from django.conf import settings | ||
from django.core.mail import EmailMultiAlternatives | ||
from django.core.management.base import BaseCommand | ||
from django.template.loader import render_to_string | ||
from django.urls import reverse | ||
from django.utils import timezone | ||
|
||
from website.models import Newsletter, NewsletterSubscriber | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class Command(BaseCommand): | ||
help = "Send published newsletter to subscribers" | ||
|
||
def add_arguments(self, parser): | ||
parser.add_argument("--newsletter_id", type=int, help="ID of the specific newsletter to send") | ||
parser.add_argument("--test", action="store_true", help="Send a test email to the admin") | ||
|
||
def handle(self, *args, **options): | ||
newsletter_id = options.get("newsletter_id") | ||
test_mode = options.get("test", False) | ||
|
||
if newsletter_id: | ||
# Send specific newsletter | ||
try: | ||
newsletter = Newsletter.objects.get(id=newsletter_id, status="published") | ||
self.stdout.write(f"Preparing to send newsletter: {newsletter.title}") | ||
self.send_newsletter(newsletter, test_mode) | ||
except Newsletter.DoesNotExist: | ||
self.stderr.write(f"Newsletter with ID {newsletter_id} does not exist or is not published") | ||
else: | ||
# Find newsletters that are published but not sent yet | ||
newsletters = Newsletter.objects.filter( | ||
status="published", email_sent=False, published_at__lte=timezone.now() | ||
) | ||
|
||
self.stdout.write(f"Found {newsletters.count()} newsletters to send") | ||
|
||
for newsletter in newsletters: | ||
self.send_newsletter(newsletter, test_mode) | ||
|
||
def send_newsletter(self, newsletter, test_mode): | ||
"""Send a specific newsletter to subscribers""" | ||
if test_mode: | ||
# Send only to admin email for testing | ||
self.stdout.write(f"Sending test email for '{newsletter.title}' to admin") | ||
if settings.ADMINS and len(settings.ADMINS) > 0: | ||
self.send_to_subscriber(settings.ADMINS[0][1], newsletter, is_test=True) | ||
else: | ||
self.stderr.write("No admin email configured. Cannot send test email.") | ||
return | ||
|
||
# Get active, confirmed subscribers | ||
subscribers = NewsletterSubscriber.objects.filter(is_active=True, confirmed=True) | ||
|
||
if subscribers.exists(): | ||
self.stdout.write(f"Sending '{newsletter.title}' to {subscribers.count()} subscribers") | ||
|
||
successful_sends = 0 | ||
for subscriber in subscribers: | ||
try: | ||
self.send_to_subscriber(subscriber.email, newsletter, subscriber=subscriber) | ||
successful_sends += 1 | ||
except Exception as e: | ||
logger.error(f"Failed to send newsletter to {subscriber.email}: {str(e)}") | ||
|
||
# Mark as sent if there were any successful sends | ||
if successful_sends > 0: | ||
newsletter.email_sent = True | ||
newsletter.email_sent_at = timezone.now() | ||
newsletter.save() | ||
|
||
self.stdout.write( | ||
self.style.SUCCESS( | ||
f"Successfully sent newsletter '{newsletter.title}' to {successful_sends} subscribers" | ||
) | ||
) | ||
else: | ||
self.stdout.write(self.style.WARNING("No active subscribers found")) | ||
|
||
def send_to_subscriber(self, email, newsletter, subscriber=None, is_test=False): | ||
"""Send the newsletter to a specific subscriber""" | ||
subject = newsletter.email_subject or f"{settings.PROJECT_NAME} Newsletter: {newsletter.title}" | ||
|
||
if is_test: | ||
subject = f"[TEST] {subject}" | ||
|
||
# Build URL scheme based on settings | ||
scheme = "https" if not settings.DEBUG else "http" | ||
|
||
# Newsletter context | ||
context = { | ||
"newsletter": newsletter, | ||
"subscriber": subscriber, | ||
"unsubscribe_url": f"{scheme}://{settings.DOMAIN_NAME}" | ||
+ reverse("newsletter_unsubscribe", args=[subscriber.confirmation_token]) | ||
if subscriber is not None | ||
else "#", | ||
"view_in_browser_url": f"{scheme}://{settings.DOMAIN_NAME}" + newsletter.get_absolute_url(), | ||
"project_name": settings.PROJECT_NAME, | ||
"recent_bugs": newsletter.get_recent_bugs(), | ||
"leaderboard": newsletter.get_leaderboard_updates(), | ||
"reported_ips": newsletter.get_reported_ips(), | ||
} | ||
|
||
# Create HTML and plain text versions | ||
html_content = render_to_string("newsletter/email/newsletter_email.html", context) | ||
text_content = f"View this newsletter in your browser: {context['view_in_browser_url']}\n\n" | ||
text_content += newsletter.content | ||
|
||
# Create email message | ||
email_message = EmailMultiAlternatives( | ||
subject=subject, body=text_content, from_email=settings.DEFAULT_FROM_EMAIL, to=[email] | ||
) | ||
|
||
email_message.attach_alternative(html_content, "text/html") | ||
email_message.send() |
78 changes: 78 additions & 0 deletions
78
website/migrations/0233_newsletter_newslettersubscriber.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
# Generated by Django 5.1.6 on 2025-03-13 09:57 | ||
|
||
import uuid | ||
|
||
import django.db.models.deletion | ||
import mdeditor.fields | ||
from django.conf import settings | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("website", "0232_bannedapp"), | ||
migrations.swappable_dependency(settings.AUTH_USER_MODEL), | ||
] | ||
|
||
operations = [ | ||
migrations.CreateModel( | ||
name="Newsletter", | ||
fields=[ | ||
("id", models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name="ID")), | ||
("title", models.CharField(max_length=255)), | ||
("slug", models.SlugField(blank=True, unique=True)), | ||
("content", mdeditor.fields.MDTextField(help_text="Write newsletter content in Markdown format")), | ||
("featured_image", models.ImageField(blank=True, null=True, upload_to="newsletter_images")), | ||
("created_at", models.DateTimeField(auto_now_add=True)), | ||
("updated_at", models.DateTimeField(auto_now=True)), | ||
("published_at", models.DateTimeField(blank=True, null=True)), | ||
( | ||
"status", | ||
models.CharField( | ||
choices=[("draft", "Draft"), ("published", "Published")], default="draft", max_length=10 | ||
), | ||
), | ||
("recent_bugs_section", models.BooleanField(default=True, help_text="Include recently reported bugs")), | ||
("leaderboard_section", models.BooleanField(default=True, help_text="Include leaderboard updates")), | ||
("reported_ips_section", models.BooleanField(default=False, help_text="Include recently reported IPs")), | ||
("email_subject", models.CharField(blank=True, max_length=255, null=True)), | ||
("email_sent", models.BooleanField(default=False)), | ||
("email_sent_at", models.DateTimeField(blank=True, null=True)), | ||
("view_count", models.PositiveIntegerField(default=0)), | ||
], | ||
options={ | ||
"verbose_name": "Newsletter", | ||
"verbose_name_plural": "Newsletters", | ||
"ordering": ["-published_at"], | ||
}, | ||
), | ||
migrations.CreateModel( | ||
name="NewsletterSubscriber", | ||
fields=[ | ||
("id", models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name="ID")), | ||
("email", models.EmailField(max_length=254, unique=True)), | ||
("name", models.CharField(blank=True, max_length=100, null=True)), | ||
("subscribed_at", models.DateTimeField(auto_now_add=True)), | ||
("is_active", models.BooleanField(default=True)), | ||
("confirmation_token", models.UUIDField(default=uuid.uuid4, editable=False)), | ||
("confirmed", models.BooleanField(default=False)), | ||
("wants_bug_reports", models.BooleanField(default=True)), | ||
("wants_leaderboard_updates", models.BooleanField(default=True)), | ||
("wants_security_news", models.BooleanField(default=True)), | ||
( | ||
"user", | ||
models.ForeignKey( | ||
blank=True, | ||
null=True, | ||
on_delete=django.db.models.deletion.SET_NULL, | ||
related_name="newsletter_subscriptions", | ||
to=settings.AUTH_USER_MODEL, | ||
), | ||
), | ||
], | ||
options={ | ||
"verbose_name": "Newsletter Subscriber", | ||
"verbose_name_plural": "Newsletter Subscribers", | ||
}, | ||
), | ||
] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.