Render Not Found Page on Invalid Path #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add mailhog as dependency * Fix auth validation (#250)
Test Results83 tests 83 ✅ 1s ⏱️ Results for commit ec0a136. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
| @@ -75,7 +76,10 @@ const AfterLogin = ({ | |||
| }); | |||
| } else { | |||
| if (!componentRole || (componentRole && componentRole === userRole)) | |||
| return <Component {...props} />; | |||
| return <> | |||
There was a problem hiding this comment.
No need to make any changes to the UI side. Just the nginx i.e. the api call is where we should return 404.
|
Fixed in #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.