Change phone number feature #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathew-jose
reviewed
Aug 28, 2024
services/identity/src/test/java/com/crapi/service/Impl/UserServiceImplTest.java
Outdated
Show resolved
Hide resolved
services/identity/src/main/java/com/crapi/constant/UserMessage.java
Outdated
Show resolved
Hide resolved
| @Size(min = 3, max = 4) | ||
| private String otp; | ||
|
|
||
| @Size(min = 3, max = 40) |
There was a problem hiding this comment.
Do we need a field for email here?
…arpawar15/crAPI into change-phoneNumber-feature
piyushroshan
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Added functionality to add change Phone Number Feature.
Testing
Unit Testing done for the functions implemented.
Checklist: