Update test and add new demos for screenshot prevention in Android #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem-generated and user-initiated snapshots, and their security implications.
…ks of screenshots, screen recordings, and nonsecure displays, while emphasizing the use of FLAG_SECURE for enhanced security.
…management in Android
…DEMO-0061 - Revise title and sample description to clarify the use of FLAG_SECURE in Activities and Dialogs. - Enhance the implementation in `MastgTest.kt` to demonstrate setting and clearing FLAG_SECURE for both Activity and Dialog. - Update `MastgTest_reversed.java` to reflect changes in the FLAG_SECURE handling. - Modify output.txt to include multiple code findings related to FLAG_SECURE usage.
…sitive data handling
…etailed guidelines for FLAG_SECURE and Recents screenshot handling in Android 13+
…re-android-screenshots-testing
There was a problem hiding this comment.
Pull Request Overview
This PR updates test and documentation for screenshot prevention in Android, adding comprehensive coverage for FLAG_SECURE, setRecentsScreenshotEnabled, and Compose dialog security. It provides new guidance for identifying sensitive screens and handling recents screenshots on Android 13+.
- Expanded test documentation with detailed guidelines for UI components, SurfaceViews, and Compose dialogs
- Added new semgrep rules for detecting improper FLAG_SECURE usage and recents screenshot handling
- Created comprehensive demo examples showing both correct and incorrect implementations
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests-beta/android/MASVS-PLATFORM/MASTG-TEST-0291.md | Expanded with detailed guidelines for FLAG_SECURE usage across different UI components |
| rules/mastg-android-sensitive-data-in-screenshot.yml | Added new detection rules for FLAG_SECURE clearing and recents screenshot control |
| prerequisites/identify-sensitive-screens.md | New guidance for identifying screens requiring screenshot protection |
| knowledge/android/MASVS-STORAGE/MASTG-KNOW-0053.md | Updated with system vs user-initiated screenshot distinctions |
| demos/android/MASVS-PLATFORM/MASTG-DEMO-0061/ | Enhanced demo showing FLAG_SECURE setting and clearing patterns |
| demos/android/MASVS-PLATFORM/MASTG-DEMO-0062/ | New demo for recents screenshot control via setRecentsScreenshotEnabled |
| demos/android/MASVS-PLATFORM/MASTG-DEMO-0063/ | New demo for Compose dialog security policies |
| best-practices/MASTG-BEST-0014.md | Updated with comprehensive screenshot prevention guidance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…On for Compose components
…t practices for overlay attacks
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cpholguera
commented
Sep 19, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…re-android-screenshots-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test and documentation for screenshot prevention in Android, adding comprehensive coverage for
FLAG_SECURE,setRecentsScreenshotEnabled, and Compose dialog security. It provides new guidance for identifying sensitive screens and handling recents screenshots on Android 13+.