-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Port MASTG-TEST-0036: Testing Enforced Updating (android) (by @appknox) #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@cpholguera The build works fine on my device, the application utilizes the dependency |
Thanks for letting me know. I think we'll need to add support for demos to "add dependencies" when needed. That'd solve the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the migration and for putting this together! I’ve added some comments that might help bring it closer to the guidelines.
One thing I noticed is that the original test (0036) might have been interpreted a bit differently — the current content + Demo don’t quite reflect the real production issue. It could help to re-read the original description for the nuance. I also tried to rephrase the issue here for clarity: https://github.com/OWASP/mastg/pull/3462/files#r2367330215
And just a small tip: if you’re using co-pilot (like in 0290.md), it often works best to first describe the issue in your own words, and then let the LLM refine it. That way the text stays closer to the intent.
Overall though, really nice progress — it’s clear you put effort into this!
@sk3l10x1ng you can now add this dependency like this: Simply add a /MASTG-DEMO-xxxx/build.gradle.kts.libs |
@cpholguera updated the changes, please check |
This PR closes #2994