Skip to content

Conversation

sk3l10x1ng
Copy link
Collaborator

@sk3l10x1ng sk3l10x1ng commented Sep 18, 2025

This PR closes #2994

@sk3l10x1ng sk3l10x1ng changed the title Port MASTG-TEST-0036: MASTG v1->v2 MASTG-TEST-0036: Testing Enforced Updating (android) Port MASTG-TEST-0036: MASTG v1->v2 MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) Sep 19, 2025
@sk3l10x1ng sk3l10x1ng closed this Sep 19, 2025
@sk3l10x1ng sk3l10x1ng reopened this Sep 19, 2025
@sk3l10x1ng sk3l10x1ng changed the title Port MASTG-TEST-0036: MASTG v1->v2 MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) Port MASTG-TEST-0036: MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) Sep 19, 2025
@sk3l10x1ng sk3l10x1ng changed the title Port MASTG-TEST-0036: MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) Sep 19, 2025
@sk3l10x1ng sk3l10x1ng changed the title MASTG-TEST-0036: Testing Enforced Updating (android) (@appknox) MASTG-TEST-0036: Testing Enforced Updating (android) (by @appknox) Sep 19, 2025
@sk3l10x1ng sk3l10x1ng changed the title MASTG-TEST-0036: Testing Enforced Updating (android) (by @appknox) Port MASTG-TEST-0036: Testing Enforced Updating (android) (by @appknox) Sep 19, 2025
@sk3l10x1ng
Copy link
Collaborator Author

@cpholguera The build works fine on my device, the application utilizes the dependency implementation("com.google.android.play:app-update-ktx:2.1.0") to check for enforced updates. This could be the reason the build fails.

@cpholguera
Copy link
Collaborator

Thanks for letting me know. I think we'll need to add support for demos to "add dependencies" when needed. That'd solve the issue.

@cpholguera cpholguera requested a review from Diolor September 22, 2025 08:23
Copy link
Collaborator

@Diolor Diolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the migration and for putting this together! I’ve added some comments that might help bring it closer to the guidelines.

One thing I noticed is that the original test (0036) might have been interpreted a bit differently — the current content + Demo don’t quite reflect the real production issue. It could help to re-read the original description for the nuance. I also tried to rephrase the issue here for clarity: https://github.com/OWASP/mastg/pull/3462/files#r2367330215

And just a small tip: if you’re using co-pilot (like in 0290.md), it often works best to first describe the issue in your own words, and then let the LLM refine it. That way the text stays closer to the intent.

Overall though, really nice progress — it’s clear you put effort into this!

@cpholguera
Copy link
Collaborator

@cpholguera The build works fine on my device, the application utilizes the dependency implementation("com.google.android.play:app-update-ktx:2.1.0") to check for enforced updates. This could be the reason the build fails.

@sk3l10x1ng you can now add this dependency like this:

https://github.com/OWASP/mastg/pull/3410/files#diff-d43bc4152a13d082c2a8c2d4b1d2416a0a9a5290a669827f6aaff626f96430f2

Simply add a /MASTG-DEMO-xxxx/build.gradle.kts.libs

@sk3l10x1ng
Copy link
Collaborator Author

@cpholguera updated the changes, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MASTG v1->v2 MASTG-TEST-0036: Testing Enforced Updating (android)

3 participants