Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cryptographic Language (e.g. "weak") #3199

Open
wants to merge 61 commits into
base: master
Choose a base branch
from

Conversation

sydseter
Copy link
Collaborator

@sydseter sydseter commented Mar 7, 2025

This PR contains:

  • Addition concerning Symmetric encryption
  • Additional advice on forward compliance with NIST
  • Additional recommendation on the use of EdDSA with Edwards448
  • Post-Quantum recommendations
  • Additional recommendations concerning the use of a key-derivation key.
  • CSPRNG alignment with ASVS.
  • Additional recommendation when using CBC with MAC.
  • Attack related to CBC-MAC
  • Removing the use of the word “weak”. Instead focusing on recommendations and advice.
  • Adding appropriate description, impact, modes of introduction and mitigations to MASWE-0010, MASWE-0021, MASWE-0024 and MASWE-0025.

This PR closes #3200.

@cpholguera cpholguera changed the title Cryptography Update Cryptographic Language (e.g. "weak") Mar 7, 2025
@sydseter
Copy link
Collaborator Author

@cpholguera What do you do with external links that return HTTP status 403 or 0, but that can be reached by human browsing?

@sydseter
Copy link
Collaborator Author

I am leaving the internal links as they are. It's ok to use the word "weak" as a general term when talking about a category of issues. My reaction and corrections is meant to make it more specific as to what we are talking about when we are referring to cryptographic concepts. A padding scheme can be predictable, the bit-size of an algorithm insufficient, input validation and crypto configuration, inappropriate or improper and so on.
I think it is better to rename the links as more MASWE gets defined. As I see it now, it isn't very problematic to leave it as it is.

@sydseter
Copy link
Collaborator Author

sydseter commented Mar 11, 2025

There is something not working with the MASTG-DEMO tests. The moment I started touching them, the matrix broke. So I am leaving them aside.

@cpholguera
Copy link
Collaborator

@cpholguera What do you do with external links that return HTTP status 403 or 0, but that can be reached by human browsing?

Is this about the GitHub action failing? You can add them to https://github.com/OWASP/owasp-mastg/blob/master/.github/workflows/config/url-checker-config.json

@cpholguera
Copy link
Collaborator

There is something not working with the MASTG-DEMO tests. The moment I started touching them, the matrix broke. So I am leaving them aside.

I just fixed the matrix. If you git pull origin master it should be fine again. Thanks for letting me know!

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick first pass for now, thanks a lot @sydseter!

@cpholguera
Copy link
Collaborator

Idea: maybe we could also build a glossary for these and other terms.

See:

sydseter and others added 19 commits March 12, 2025 01:53
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@sydseter sydseter requested a review from cpholguera March 12, 2025 02:45
@sydseter
Copy link
Collaborator Author

Idea: maybe we could also build a glossary for these and other terms.

See:

Done.

@sydseter
Copy link
Collaborator Author

There is something not working with the MASTG-DEMO tests. The moment I started touching them, the matrix broke. So I am leaving them aside.

I just fixed the matrix. If you git pull origin master it should be fine again. Thanks for letting me know!

Updated MASTG-DEMO tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarifying Cryptographic Language (e.g. "weak") in MASTG-TEST-0210 & MASTG-TEST-0211
2 participants