Only run APK/IPA builds on changes demos in PRs only #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests in Android and iOS builds and restrict them to only changes in the PR.
…N.SDK_INT for OS version check
…to include specific MASTG-DEMO patterns
javier-ruiz-b
approved these changes
Mar 8, 2025
|
|
||
| - name: Generate matrix | ||
| id: set-matrix | ||
| run: | | ||
| matrix="$(echo demos/android/*/MASTG-DEMO-* | sed 's/ /","/g')" | ||
| echo "matrix={\"demo\":[\"$matrix\"]}" >> $GITHUB_OUTPUT | ||
| if [ "${{ github.event_name }}" = "pull_request" ]; then |
There was a problem hiding this comment.
Great idea! The script is good as it is, I don't think it's necessary to improve it.
I am thinking in extracting the script into a separate file, because it is very similar between iOS and Android. For example:
.github/workflows/matrix-demos-json.sh
#!/bin/bash
set -eu
event_name="$1" # check for "pull_request"
pr_commit_hash="$2"
demo_path="$3" # demos/android or demos/ios
...The idea is to shorten the step to something like this:
- name: Generate matrix
id: set-matrix
run: |
event_name="${{ github.event_name }}"
pr_hash="${{ github.event.pull_request.base.sha }}"
.github/workflows/matrix-demos-json.sh "$event_name" "$pr_hash" demos/android >> $GITHUB_OUTPUT
There was a problem hiding this comment.
That'd be really nice, let's do that on a separate PR. Thanks a lot!
cpholguera
deleted the
3204-optimize-apk-and-ipa-build-actions-to-run-only-on-relevant-changes-in-prs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3204
This PR optimizes the GitHub Action for building Android and iOS demos by modifying its behavior based on the event type:
demos/android/**ordemos/ios/**have changed, reducing unnecessary builds. This is achieved by usinggit diffto detect modified files and updating the matrix accordingly.This improves CI efficiency by avoiding redundant builds when no relevant changes are made.
Additional changes: Demo download buttons
This PR also updated the script that ensures that the last successful run of the GitHub Action was on the master branch.
docs/hooks/github_api.pydocs/hooks/maswe-beta-banner.pyin theget_android_demo_buttonsandget_android_demo_buttonsmethods.Previously, the script fetched the most recent successful run without checking the branch, which could lead to using artifacts from non-master branches. Now, it explicitly filters for successful runs on master, ensuring that only stable and merged builds are considered.