_addModuleSettings: Check getShopConfVar() before getConfigParam() #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fVar() but not getConfigParam(). Module Internals will not see a db-value in these cases and try to save the default-value, which will then override the actual value the module had stored somewhere. (Module internals will always show "Fixed state" for such modules in the module list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some third-party-modules (eg "dd_faq") only seem to extend getShopConfVar() but not getConfigParam(). Module Internals will not see a db-value in these cases and try to save the default-value, which will then override the actual value the module had stored somewhere.
(Module internals will always show "Fixed state" for such modules in the module list)
As workaround getShopConfVar() could be checked first and getConfigParam() can be called as fallback.