Skip to content

Conversation

nzjess
Copy link

@nzjess nzjess commented Dec 14, 2021

make branch name to merge a command line parameter, since folks seem to be using "main" a lot these days, rather than "master"

@nzjess nzjess force-pushed the make-branch-name-a-command-line-parameter branch from 1d87164 to b3f410d Compare December 14, 2021 11:03
Copy link
Member

@chrishiestand chrishiestand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thank you! Let's just set the default to main

echo "usage: $self_name filename (where filename is in format \"name url(\n)name url\")"
echo "usage: $self_name filename [branchname]"
echo " filename - where filename is in format \"name url(\n)name url\""
echo " branchname - name of branch to merge (default \"master\")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just set the default to main :-)


data_file="$1"
name_urls="$(cat $data_file)"
branch_name="${2:-master}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants