Merge pull request #326 from OasisDEX/improvement-random-fails-2

Improvement for random fails - Ajna - Open position
OasisDEX · May 24, 2024 · fc4bb6e · fc4bb6e
2 parents 4cdeb34 + 2503588
commit fc4bb6e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/tests/sharedTestSteps/positionManagement.ts b/tests/sharedTestSteps/positionManagement.ts
@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
 import * as metamask from '@synthetixio/synpress/commands/metamask';
 import * as tx from 'utils/tx';
 import { App } from 'src/app';
-import { longTestTimeout, positionTimeout } from 'utils/config';
+import { expectDefaultTimeout, longTestTimeout, positionTimeout } from 'utils/config';
 import { Reason } from 'src/pages/position/swap';
 
 type ActionData = { token: string; amount: string };
@@ -78,7 +78,14 @@ export const openPosition = async ({
 		//   - 'Reload' added to avoid flakines
 		await app.page.reload();
 		await app.position.setup.goToPosition();
-		await app.position.overview.shouldBeVisible();
+		await expect(async () => {
+			const applicationError = app.page.getByText('Aplication error:');
+
+			if (await applicationError.isVisible()) {
+				await app.page.reload();
+			}
+			await app.position.overview.shouldBeVisible();
+		}).toPass({ timeout: expectDefaultTimeout * 4 });
 	} else {
 		await app.position.setup.goToPositionShouldBeVisible();
 		const positionId: string = await app.position.setup.getNewPositionId();
@@ -87,7 +94,14 @@ export const openPosition = async ({
 		//
 		await expect(async () => {
 			await app.page.goto(positionId);
-			await app.position.overview.shouldBeVisible();
+			await expect(async () => {
+				const applicationError = app.page.getByText('Aplication error:');
+
+				if (await applicationError.isVisible()) {
+					await app.page.reload();
+				}
+				await app.position.overview.shouldBeVisible();
+			}).toPass({ timeout: expectDefaultTimeout * 4 });
 		}).toPass();
 
 		return positionId;

diff --git a/tests/withWallet/ajna/base/ajnaBorrowBase.spec.ts b/tests/withWallet/ajna/base/ajnaBorrowBase.spec.ts
@@ -89,7 +89,6 @@ test.describe('Ajna Base Borrow - Wallet connected', async () => {
 			existingDPM: true,
 			deposit: { token: 'WSTETH', amount: '2' },
 			borrow: { token: 'ETH', amount: '1' },
-			protocol: 'Ajna',
 		});
 	});