fix: remove slippage from swap quote calculation

OasisDEX · Apr 30, 2024 · 626a57b · 626a57b
1 parent 8429737
commit 626a57b
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 9 deletions.
diff --git a/sdk/sdk-server/src/handlers/getSwapQuote.ts b/sdk/sdk-server/src/handlers/getSwapQuote.ts
@@ -18,6 +18,5 @@ export const getSwapQuoteExactInput = publicProcedure
       chainInfo: opts.input.chainInfo,
       fromAmount: opts.input.fromAmount,
       toToken: opts.input.toToken,
-      slippage: opts.input.slippage,
     })
   })
diff --git a/sdk/simulator-service/src/implementation/utils/GetSwapStepData.ts b/sdk/simulator-service/src/implementation/utils/GetSwapStepData.ts
@@ -38,7 +38,6 @@ export async function getSwapStepData(params: {
       chainInfo: params.chainInfo,
       fromAmount: amountAfterSummerFee,
       toToken: params.toToken,
-      slippage: params.slippage,
     }),
     params.swapManager.getSpotPrice({
       chainInfo: params.chainInfo,

diff --git a/sdk/swap-common/src/interfaces/ISwapManager.ts b/sdk/swap-common/src/interfaces/ISwapManager.ts
@@ -43,7 +43,6 @@ export interface ISwapManager {
     chainInfo: ChainInfo
     fromAmount: TokenAmount
     toToken: Token
-    slippage: Percentage
   }): Promise<QuoteData>
 
   /**

diff --git a/sdk/swap-common/src/interfaces/ISwapProvider.ts b/sdk/swap-common/src/interfaces/ISwapProvider.ts
@@ -39,7 +39,6 @@ export interface ISwapProvider {
     chainInfo: ChainInfo
     fromAmount: TokenAmount
     toToken: Token
-    slippage: Percentage
   }): Promise<QuoteData>
 
   /**

diff --git a/sdk/swap-service/src/implementation/SwapManager.ts b/sdk/swap-service/src/implementation/SwapManager.ts
@@ -42,7 +42,6 @@ export class SwapManager implements ISwapManager {
     chainInfo: ChainInfo
     fromAmount: TokenAmount
     toToken: Token
-    slippage: Percentage
     forceUseProvider?: SwapProviderType
   }): Promise<QuoteData> {
     const provider: Maybe<ISwapProvider> = this._getBestProvider(params)

diff --git a/sdk/swap-service/src/implementation/oneinch/OneInchSwapProvider.ts b/sdk/swap-service/src/implementation/oneinch/OneInchSwapProvider.ts
@@ -111,7 +111,6 @@ export class OneInchSwapProvider implements ISwapProvider {
     chainInfo: ChainInfo
     fromAmount: TokenAmount
     toToken: Token
-    slippage: Percentage
   }): Promise<QuoteData> {
     const swapUrl = this._formatOneInchQuoteUrl({
       chainInfo: params.chainInfo,
@@ -133,15 +132,13 @@ export class OneInchSwapProvider implements ISwapProvider {
 
     const responseData = (await response.json()) as OneInchQuoteResponse
 
-    const One = Percentage.createFrom({ value: 100 })
-
     return {
       provider: SwapProviderType.OneInch,
       fromTokenAmount: params.fromAmount,
       toTokenAmount: TokenAmount.createFromBaseUnit({
         token: params.toToken,
         amount: responseData.toTokenAmount,
-      }).multiply(One.subtract(params.slippage)),
+      }),
       routes: this._extractSwapRoutes(responseData.protocols),
       estimatedGas: responseData.estimatedGas,
     }