Fixed comments

OasisDEX · Jul 12, 2024 · fd179e9 · fd179e9
1 parent a5c25b2
commit fd179e9
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 18 deletions.
diff --git a/sdk/earn-protocol-service/src/implementation/EarnProtocolManager.ts b/sdk/earn-protocol-service/src/implementation/EarnProtocolManager.ts
@@ -92,9 +92,9 @@ export class EarnProtocolManager implements IEarnProtocolManager {
           value: '0',
         },
         description:
-          'Deposit ' +
+          'Withdraw ' +
           params.amount.toString() +
-          ' to Fleet at address: ' +
+          ' from Fleet at address: ' +
           params.fleetAddress.value,
       },
     ]

diff --git a/sdk/sdk-e2e/tests/earnProtocol.test.ts b/sdk/sdk-e2e/tests/earnProtocol.test.ts
@@ -54,8 +54,9 @@ describe.skip('Earn Protocol Deposit', () => {
     expect(user.chainInfo).toEqual(chain.chainInfo)
   })
 
-  it('should deposit correct token', async () => {
-    const depositToken = USDC
+  it('should deposit 1 USDC', async () => {
+    const token = USDC
+    const amount = '1'
 
     const fleet = chain.earnProtocol.getFleet({
       address: config.fleetAddress,
@@ -65,16 +66,17 @@ describe.skip('Earn Protocol Deposit', () => {
     const transactions = await fleet.deposit({
       user: getUserWorkaround(user),
       amount: TokenAmount.createFrom({
-        amount: '1',
-        token: depositToken,
+        amount,
+        token,
       }),
     })
 
     await sendAndLogTransactions(transactions)
   })
 
-  it('should fail deposit with incorrect token with appropriate error', async () => {
-    const depositToken = DAI
+  it('should fail deposit of DAI with incorrect token error', async () => {
+    const token = DAI
+    const amount = '1'
 
     const fleet = chain.earnProtocol.getFleet({
       address: config.fleetAddress,
@@ -84,8 +86,28 @@ describe.skip('Earn Protocol Deposit', () => {
     const transactions = await fleet.deposit({
       user: getUserWorkaround(user),
       amount: TokenAmount.createFrom({
-        amount: '1',
-        token: depositToken,
+        amount,
+        token,
+      }),
+    })
+
+    await sendAndLogTransactions(transactions)
+  })
+
+  it('should withdraw 1 USDC', async () => {
+    const token = USDC
+    const amount = '1'
+
+    const fleet = chain.earnProtocol.getFleet({
+      address: config.fleetAddress,
+    })
+    assert(fleet, 'Fleet not found')
+
+    const transactions = await fleet.withdraw({
+      user: getUserWorkaround(user),
+      amount: TokenAmount.createFrom({
+        amount,
+        token,
       }),
     })
 

diff --git a/sdk/sdk-server/src/context/CreateProtocolPluginsRegistry.ts b/sdk/sdk-server/src/context/CreateProtocolPluginsRegistry.ts
@@ -19,19 +19,24 @@ import { ChainFamilyMap } from '@summerfi/sdk-common'
  */
 export function createProtocolsPluginsRegistry(params: {
   configProvider: ConfigurationProvider
-  blokchainClientProvider: IBlockchainClientProvider
+  blockchainClientProvider: IBlockchainClientProvider
   tokensManager: ITokensManager
   oracleManager: IOracleManager
   swapManager: ISwapManager
   addressBookManager: IAddressBookManager
 }): IProtocolPluginsRegistry {
-  const { blokchainClientProvider, addressBookManager, swapManager, tokensManager, oracleManager } =
-    params
+  const {
+    blockchainClientProvider,
+    addressBookManager,
+    swapManager,
+    tokensManager,
+    oracleManager,
+  } = params
 
   return new ProtocolPluginsRegistry({
     plugins: ProtocolPluginsRecord,
     context: {
-      provider: blokchainClientProvider.getBlockchainClient({
+      provider: blockchainClientProvider.getBlockchainClient({
         chainInfo: ChainFamilyMap.Ethereum.Mainnet,
       }),
       tokensManager,

diff --git a/sdk/sdk-server/src/context/SDKContext.ts b/sdk/sdk-server/src/context/SDKContext.ts
@@ -26,7 +26,7 @@ export type SDKContextOptions = CreateAWSLambdaContextOptions<APIGatewayProxyEve
 export type SDKAppContext = {
   addressBookManager: IAddressBookManager
   configProvider: IConfigurationProvider
-  blokchainClientProvider: BlockchainnClientProvider
+  blockchainClientProvider: BlockchainnClientProvider
   tokensManager: ITokensManager
   swapManager: ISwapManager
   oracleManager: IOracleManager
@@ -40,15 +40,15 @@ export type SDKAppContext = {
 // context for each request
 export const createSDKContext = (opts: SDKContextOptions): SDKAppContext => {
   const configProvider = new ConfigurationProvider()
-  const blokchainClientProvider = new BlockchainnClientProvider({ configProvider })
+  const blockchainClientProvider = new BlockchainnClientProvider({ configProvider })
   const addressBookManager = AddressBookManagerFactory.newAddressBookManager({ configProvider })
   const tokensManager = TokensManagerFactory.newTokensManager({ configProvider })
   const orderPlannerService = new OrderPlannerService()
   const swapManager = SwapManagerFactory.newSwapManager({ configProvider })
   const oracleManager = OracleManagerFactory.newOracleManager({ configProvider })
   const protocolsRegistry = createProtocolsPluginsRegistry({
     configProvider,
-    blokchainClientProvider,
+    blockchainClientProvider: blockchainClientProvider,
     tokensManager,
     oracleManager,
     swapManager,
@@ -65,7 +65,7 @@ export const createSDKContext = (opts: SDKContextOptions): SDKAppContext => {
 
   return {
     configProvider,
-    blokchainClientProvider,
+    blockchainClientProvider: blockchainClientProvider,
     addressBookManager,
     tokensManager,
     swapManager,