feat: add simulated swap data to simulations #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14942: Provide Swap Data view for FE. |
piotrwitek
previously requested changes
Mar 26, 2024
robercano
previously approved these changes
Apr 2, 2024
sdk/simulator-service/src/implementation/simulator-engine/reducer/swapReducer.ts
Show resolved
Hide resolved
sdk/simulator-service/src/implementation/utils/SimulatorUtils.ts
Outdated
Show resolved
Hide resolved
sdk/simulator-service/src/strategies/refinance/RefinanceLendingToLending.ts
Show resolved
Hide resolved
zerotucks
changed the title
robercano
approved these changes
Apr 3, 2024
sdk/simulator-service/src/implementation/utils/SimulatorUtils.ts
Outdated
Show resolved
Hide resolved
zerotucks
dismissed
piotrwitek’s stale review
Rob has covered this and Piter is pretty busy
jakubswierczek
pushed a commit
that referenced
this pull request
Apr 8, 2024
- Add Swaps to Simulation output - Refactor `Simulation` -> `ISimulation` to align better with rest of the SDK - Refactor Swap related types from `swap-common` -> `sdk-common` to remove cyclic dependencies in simulation types Note: - `getSpotPrices` simplified to `getSpotPrice` in #153 TODO: - Write tests for simulation swaps (done in #153) - Update refinance strategy to handle swaps (current implementation is based on assumptions that no longer hold following ProtocolManager/Plugins/Pool work) (done in #153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation->ISimulationto align better with rest of the SDKswap-common->sdk-commonto remove cyclic dependencies in simulation typesNote:
getSpotPricessimplified togetSpotPricein feat: add any pair capability to refinance strategy #153TODO: