Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish packages to npmjs #155

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Publish packages to npmjs #155

merged 4 commits into from
Apr 5, 2024

Conversation

cristidas
Copy link
Contributor

  • Publish sdk/sdk-common and 'sdk/sdk-client' as packages to npmjs
  • Trigger automatically on version changes to main branch or manually for code on dev and main branches`

@cristidas cristidas self-assigned this Apr 4, 2024
@cristidas cristidas closed this Apr 4, 2024
@cristidas cristidas reopened this Apr 4, 2024
@cristidas cristidas changed the base branch from dev to pw/sdk-publish-poc April 4, 2024 14:25
sanbotto
sanbotto approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sanbotto sanbotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piotrwitek
piotrwitek requested changes Apr 5, 2024
View reviewed changes
sdk/sdk-client/package.json Outdated Show resolved Hide resolved
sdk/sdk-common/package.json Outdated Show resolved Hide resolved
.github/workflows/publish-client-package.yaml Outdated Show resolved Hide resolved
.github/workflows/publish-client-package.yaml Outdated Show resolved Hide resolved
.github/workflows/publish-client-package.yaml Outdated Show resolved Hide resolved
.github/workflows/publish-common-package.yaml Outdated Show resolved Hide resolved
piotrwitek
piotrwitek approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@cristidas cristidas merged commit d5f55dc into pw/sdk-publish-poc Apr 5, 2024
2 checks passed
@cristidas cristidas deleted the TECH-3055-publish-packages branch April 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbotto sanbotto sanbotto approved these changes

@nickkounz nickkounz nickkounz approved these changes

@piotrwitek piotrwitek piotrwitek approved these changes

@eskp eskp Awaiting requested review from eskp

@OleksandrUA OleksandrUA Awaiting requested review from OleksandrUA

@jeannettemcd jeannettemcd Awaiting requested review from jeannettemcd

Assignees

@cristidas cristidas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristidas @piotrwitek @nickkounz @sanbotto