Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinance any pair fixes #193

Merged
merged 18 commits into from
Apr 24, 2024
Merged

Refinance any pair fixes #193

merged 18 commits into from
Apr 24, 2024

Conversation

paszkowskiDamian
Copy link
Contributor

No description provided.

@paszkowskiDamian paszkowskiDamian marked this pull request as ready for review April 22, 2024 15:08
robercano
robercano previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@robercano robercano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a couple suggestions. I'll approve, but please consider fixing those if possible

sdk/simulator-service/src/implementation/simulator-engine/reducer/swapReducer.ts Show resolved Hide resolved
sdk/simulator-service/src/strategies/refinanceAnyPair/RefinanceLendingToLendingAnyPair.ts Show resolved Hide resolved
robercano
robercano previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@robercano robercano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of minor fixes. I'll approve anyway

sdk/sdk-common/src/common/implementation/Price.ts Outdated Show resolved Hide resolved
sdk/simulator-service/src/strategies/refinanceAnyPair/RefinanceLendingToLendingAnyPair.ts Show resolved Hide resolved
@paszkowskiDamian paszkowskiDamian merged commit cc9f699 into dev Apr 24, 2024
2 checks passed
@paszkowskiDamian paszkowskiDamian deleted the damianpaszkowski/test-any-pair-refinance branch April 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerotucks zerotucks zerotucks approved these changes

@robercano robercano robercano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paszkowskiDamian @robercano @zerotucks