Refactor APY calculation logic #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to calculate the Average Percentage Yield (APY) for each day, and for specific periods (i.e., 7, 30, 90, 365 days) has been refactored for optimization. APY calculation is now performed over actual data length, eliminating the division over fixed period values. The results are also systematically sorted by timestamp for consistent retrieval of data.
marcinciarka
previously approved these changes
Apr 23, 2024
In the 'curated-yield-pools.ts' file, the latest change includes adding the MEVETH yield pool. Additionally, WEETH and EZETH identifiers have been commented out for now. This was likely done due to changes or updates within the respective pools or protocol.
marcinciarka
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to calculate the Average Percentage Yield (APY) for each day, and for specific periods (i.e., 7, 30, 90, 365 days) has been refactored for optimization. APY calculation is now performed over actual data length, eliminating the division over fixed period values. The results are also systematically sorted by timestamp for consistent retrieval of data.