Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PNPM and Turbo versions #555

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Update PNPM and Turbo versions #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/publish-sdk-package/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
- name: Setup pnpm
uses: pnpm/action-setup@v3
with:
version: 8
version: 9.12.3

- name: Install dependencies
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-unit-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-earn-protocol-landing-page-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-earn-protocol-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3
Comment on lines +70 to +72
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Most humbly requesting your attention to the Turbo version, your majesty.

Your gracious PR objectives mention upgrading Turbo to version 2.2.3, but I notice with utmost respect that this version specification appears to be missing in the workflow. Might I suggest, with your permission:

  1. Consider specifying the Turbo version in the workflow to ensure consistency
  2. Evaluate if rharkor/caching-for-turbo@v1.5 supports Turbo 2.2.3

If it pleases you, here's a suggested modification:

      - name: Set up turbo cache
        uses: rharkor/caching-for-turbo@v1.5
+       with:
+         turbo-version: 2.2.3

Committable suggestion skipped: line range outside the PR's diff.


- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-rays-dashboard-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-rays-dashboard-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-sdk-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-sdk-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ jobs:
- name: Set up turbo cache
uses: rharkor/caching-for-turbo@v1.5

- uses: pnpm/action-setup@v2.0.1
- uses: pnpm/action-setup@v3
with:
version: 8.14.1
version: 9.12.3

- name: Setup Node.js environment
uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion apps/earn-protocol-landing-page/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
"json-to-ts": "^1.7.0",
"node-fetch": "^2.7.0"
},
"packageManager": "pnpm@8.15.4"
"packageManager": "pnpm@9.12.3"
}
2 changes: 1 addition & 1 deletion apps/earn-protocol/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,5 @@
"tailwindcss": "^3.4.4",
"@types/react-infinite-scroller": "^1.2.5"
},
"packageManager": "pnpm@8.15.4"
"packageManager": "pnpm@9.12.3"
}
2 changes: 1 addition & 1 deletion apps/rays-dashboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@
"json-to-ts": "^1.7.0",
"node-fetch": "^2.7.0"
},
"packageManager": "pnpm@8.15.4"
"packageManager": "pnpm@9.12.3"
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@
"ts-jest": "^29.1.2",
"tsc-alias": "^1.8.8",
"tsx": "^4.16.5",
"turbo": "^2.1.2",
"turbo": "^2.2.3",
"typescript": "^5.6.2",
"zx": "^8.0.1"
},
"name": "summerfi-monorepo",
"packageManager": "pnpm@8.15.4",
"packageManager": "pnpm@9.12.3",
"engines": {
"node": ">=20"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@vercel/style-guide": "^6.0.0",
"eslint-config-next": "14.2.3",
"eslint-config-prettier": "^9.1.0",
"eslint-config-turbo": "^2.1.2",
"eslint-config-turbo": "^2.2.3",
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-deprecation": "2.0.0",
"eslint-plugin-import": "^2.29.1",
Expand Down
Loading
Loading