Hardening threshold parameter checks

cmd/createcluster.go

@@ -324,6 +324,15 @@ func validateCreateConfig(ctx context.Context, conf clusterConfig) error {
 		return errors.New("missing --nodes flag")
 	}
 
+	// check for threshold parameter
+	if conf.Threshold < 2 {
+		return errors.New("threshold cannot be smaller than 2", z.Int("threshold", conf.Threshold))
+	}
+	if conf.Threshold > conf.NumNodes {
+		return errors.New("threshold cannot be greater than number of operators",
+			z.Int("threshold", conf.Threshold), z.Int("operators", conf.NumNodes))
+	}
+
 	// Check for valid network configuration.
 	if err := validateNetworkConfig(conf); err != nil {
 		return errors.Wrap(err, "get network config")

cmd/createdkg.go

@@ -181,6 +181,10 @@ func validateWithdrawalAddrs(addrs []string, network string) error {
 
 // validateDKGConfig returns an error if any of the provided config parameter is invalid.
 func validateDKGConfig(threshold, numOperators int, network string, depositAmounts []int) error {
+	if threshold < 2 {
+		return errors.New("threshold cannot be smaller than 2", z.Int("threshold", threshold))
+	}
+
 	if threshold > numOperators {
 		return errors.New("threshold cannot be greater than length of operators",
 			z.Int("threshold", threshold), z.Int("operators", numOperators))