Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsigex: remove unmarshal logs #2459

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jul 21, 2023

This reverts commit 6075930, since we identified the cause for the unmarshaling error.

category: misc
ticket: #2433

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (f20b602) 53.77% compared to head (0061211) 53.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
+ Coverage   53.77%   53.80%   +0.03%     
==========================================
  Files         198      198              
  Lines       26506    26501       -5     
==========================================
+ Hits        14253    14260       +7     
+ Misses      10490    10479      -11     
+ Partials     1763     1762       -1     
Impacted Files Coverage Δ
core/parsigex/parsigex.go 62.79% <ø> (+2.11%) ⬆️
core/proto.go 63.29% <0.00%> (+0.66%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 24, 2023
@obol-bulldozer obol-bulldozer bot merged commit 0ca56e6 into main Jul 24, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/revert_parsigex_broadcastlog branch July 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants