Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: rename ShouldRun #2463

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jul 24, 2023

Rename ShouldRun to MaybeStart as per @corverroos 's suggestion: 8ad5803#r122236580

category: misc
ticket: none

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 40.00% and no project coverage change.

Comparison is base (bdadb8d) 53.70% compared to head (4bb8edc) 53.70%.

❗ Current head 4bb8edc differs from pull request most recent head 692ebbe. Consider uploading reports for the commit 692ebbe to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage   53.70%   53.70%           
=======================================
  Files         198      198           
  Lines       26506    26506           
=======================================
+ Hits        14234    14235    +1     
+ Misses      10510    10505    -5     
- Partials     1762     1766    +4     
Impacted Files Coverage Δ
core/consensus/component.go 66.88% <40.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 24, 2023
@obol-bulldozer obol-bulldozer bot merged commit 748a434 into main Jul 24, 2023
9 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/renamemaybestart branch July 24, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants