app/log: decrease default log filter from 1h to 12s #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
- Coverage 53.83% 53.79% -0.04%
==========================================
Files 198 198
Lines 26501 26501
==========================================
- Hits 14267 14257 -10
- Misses 10474 10486 +12
+ Partials 1760 1758 -2
☔ View full report in Codecov by Sentry. |
xenowits
changed the title
xenowits
approved these changes
Jul 25, 2023
dB2510
approved these changes
Jul 25, 2023
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think an hour is maybe too much, it is hiding information. Once a slot (every 12 secs) feels better. VC triggered logs are often roughly once a slot per type. So this would have same visibility level.
category: refactor
ticket: none